Fix deprecated pytest.warns(None)

Author: Armavica

pymc/tests/test_distributions.py

@@ -14,6 +14,7 @@
 import functools
 import itertools
 import sys
+import warnings
 
 import aesara
 import aesara.tensor as at
@@ -3288,9 +3289,9 @@ def test_no_warning_logp(self):
         with pm.Model() as m:
             sd_dist = pm.Exponential.dist(1, size=3)
             x = pm.LKJCholeskyCov("x", n=3, eta=1, sd_dist=sd_dist)
-        with pytest.warns(None) as record:
+        with warnings.catch_warnings():
+            warnings.simplefilter("error")
             m.logp()
-        assert not record
 
     @pytest.mark.parametrize(
         "sd_dist",

pymc/tests/test_math.py

@@ -12,6 +12,8 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 
+import warnings
+
 import aesara
 import aesara.tensor as at
 import numpy as np
@@ -154,9 +156,9 @@ def test_log1mexp():
 
 def test_log1mexp_numpy_no_warning():
     """Assert RuntimeWarning is not raised for very small numbers"""
-    with pytest.warns(None) as record:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         log1mexp_numpy(-1e-25, negative_input=True)
-    assert not record
 
 
 def test_log1mexp_numpy_integer_input():
@@ -170,17 +172,18 @@ def test_log1mexp_deprecation_warnings():
     ):
         res_pos = log1mexp_numpy(2)
 
-    with pytest.warns(None) as record:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         res_neg = log1mexp_numpy(-2, negative_input=True)
-    assert not record
 
     with pytest.warns(
         FutureWarning,
         match="pymc.math.log1mexp will expect a negative input",
     ):
         res_pos_at = log1mexp(2).eval()
 
-    with pytest.warns(None):
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         res_neg_at = log1mexp(-2, negative_input=True).eval()
 
     assert np.isclose(res_pos, res_neg)
@@ -262,9 +265,9 @@ def test_invlogit_deprecation_warning():
     ):
         res = invlogit(np.array(-750.0), 1e-5).eval()
 
-    with pytest.warns(None) as record:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         res_zero_eps = invlogit(np.array(-750.0)).eval()
-    assert not record
 
     assert np.isclose(res, res_zero_eps)
 
@@ -280,11 +283,10 @@ def test_softmax_logsoftmax_no_warnings(aesara_function, pymc_wrapper):
     """Test that wrappers for aesara functions do not issue Warnings"""
 
     vector = at.vector("vector")
-    with pytest.warns(None) as record:
+    with pytest.warns(Warning) as record:
         aesara_function(vector)
-    warnings = {warning.category for warning in record.list}
-    assert warnings == {UserWarning, FutureWarning}
+    assert {w.category for w in record.list} == {UserWarning, FutureWarning}
 
-    with pytest.warns(None) as record:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         pymc_wrapper(vector)
-    assert not record

pymc/tests/test_mixture.py

@@ -12,6 +12,8 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 
+import warnings
+
 from contextlib import ExitStack as does_not_raise
 
 import aesara
@@ -655,10 +657,10 @@ def mixmixlogp(value, point):
         assert_allclose(priorlogp + mixmixlogpg.sum(), model.logp(test_point), rtol=rtol)
 
     def test_iterable_single_component_warning(self):
-        with pytest.warns(None) as record:
+        with warnings.catch_warnings():
+            warnings.simplefilter("error")
             Mixture.dist(w=[0.5, 0.5], comp_dists=Normal.dist(size=2))
             Mixture.dist(w=[0.5, 0.5], comp_dists=[Normal.dist(size=2), Normal.dist(size=2)])
-        assert not record
 
         with pytest.warns(UserWarning, match="Single component will be treated as a mixture"):
             Mixture.dist(w=[0.5, 0.5], comp_dists=[Normal.dist(size=2)])
@@ -1303,9 +1305,9 @@ def test_logp(self):
     def test_warning(self):
         with Model() as m:
             comp_dists = [HalfNormal.dist(), Exponential.dist(1)]
-            with pytest.warns(None) as rec:
+            with warnings.catch_warnings():
+                warnings.simplefilter("error")
                 Mixture("mix1", w=[0.5, 0.5], comp_dists=comp_dists)
-            assert not rec
 
             comp_dists = [Uniform.dist(0, 1), Uniform.dist(0, 2)]
             with pytest.warns(MixtureTransformWarning):
@@ -1315,16 +1317,16 @@ def test_warning(self):
             with pytest.warns(MixtureTransformWarning):
                 Mixture("mix3", w=[0.5, 0.5], comp_dists=comp_dists)
 
-            with pytest.warns(None) as rec:
+            with warnings.catch_warnings():
+                warnings.simplefilter("error")
                 Mixture("mix4", w=[0.5, 0.5], comp_dists=comp_dists, transform=None)
-            assert not rec
 
-            with pytest.warns(None) as rec:
+            with warnings.catch_warnings():
+                warnings.simplefilter("error")
                 Mixture("mix5", w=[0.5, 0.5], comp_dists=comp_dists, observed=1)
-            assert not rec
 
             # Case where the appropriate default transform is None
             comp_dists = [Normal.dist(), Normal.dist()]
-            with pytest.warns(None) as rec:
+            with warnings.catch_warnings():
+                warnings.simplefilter("error")
                 Mixture("mix6", w=[0.5, 0.5], comp_dists=comp_dists)
-            assert not rec

pymc/tests/test_model_graph.py

@@ -11,6 +11,8 @@
 #   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
+import warnings
+
 import aesara
 import numpy as np
 import pytest
@@ -271,7 +273,8 @@ class TestRadonModel(BaseModelGraphTest):
     model_func = radon_model
 
     def test_checks_formatting(self):
-        with pytest.warns(None):
+        with warnings.catch_warnings():
+            warnings.simplefilter("error")
             model_to_graphviz(self.model, formatting="plain")
         with pytest.raises(ValueError, match="Unsupported formatting"):
             model_to_graphviz(self.model, formatting="latex")

pymc/tests/test_sampling_jax.py

@@ -1,3 +1,5 @@
+import warnings
+
 from typing import Any, Callable, Dict, Optional
 from unittest import mock
 
@@ -113,9 +115,9 @@ def test_get_jaxified_graph():
     # be removed once https://github.com/aesara-devs/aesara/issues/637 is sorted.
     x = at.scalar("x")
     y = at.exp(x)
-    with pytest.warns(None) as record:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         fn = get_jaxified_graph(inputs=[x], outputs=[y])
-    assert not record
     assert np.isclose(fn(0), 1)
 
 

pymc/tests/test_shape_handling.py

@@ -12,6 +12,8 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 
+import warnings
+
 import aesara
 import numpy as np
 import pytest
@@ -238,7 +240,8 @@ def test_param_and_batch_shape_combos(
         with pm.Model(coords=coords) as pmodel:
             mu = aesara.shared(np.random.normal(size=param_shape))
 
-            with pytest.warns(None):
+            with warnings.catch_warnings():
+                warnings.simplefilter("error")
                 if parametrization == "implicit":
                     rv = pm.Normal("rv", mu=mu).shape == param_shape
                 else: