Fix crash on uninferable decorators on Python 3.6 and 3.7 #5549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Pull Request Test Coverage Report for Build 1594218126
💛 - Coveralls |
pylint/checkers/utils.py
Outdated
Comment on lines
882
to
883
| else: | ||
| continue |
Member
There was a problem hiding this comment.
It look like this is never used, maybe we can remove it ? Beside right now nothing is exactly the same behavior, right ?
Suggested change
| else: | |
| continue |
Collaborator
Author
There was a problem hiding this comment.
This is used on 3.6 and 3.7. Coveralls is reported on 3.8 (I believe) that's why the coverage dropped. I have added a pragma: no cover.
mbyrnepr2
reviewed
Dec 17, 2021
mbyrnepr2
reviewed
Dec 17, 2021
Co-authored-by: Mark Byrne <[email protected]>
Member
|
Thank you for the headsup @DanielNoord much appreciated and thanks for catching it & fixing. |
mbyrnepr2
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
Crash identified while working on #5547
Tagging @mbyrnepr2 since you contributed this checker and I wonder if you have an opinion on this fix.