Skip to content

Fix false-positive for bare-name-capture-pattern #10648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

Fix false-positive for bare-name-capture-pattern #10648

merged 2 commits into from
Oct 13, 2025

Conversation

@cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 13, 2025

Closes #10647

@cdce8p cdce8p added this to the 4.0.1 milestone Oct 13, 2025
@cdce8p cdce8p added False Positive 🦟 A message is emitted but nothing is wrong with the code Match case backport maintenance/4.0.x labels Oct 13, 2025
@cdce8p cdce8p mentioned this pull request Oct 13, 2025
Closed
@codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.96%. Comparing base (3de1fbc) to head (12414c3).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10648   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         176      176           
  Lines       19502    19521   +19     
=======================================
+ Hits        18715    18734   +19     
  Misses        787      787
Files with missing lines Coverage Δ
pylint/checkers/match_statements_checker.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pierre-Sassoulas
Pierre-Sassoulas previously approved these changes Oct 13, 2025
View reviewed changes
@cdce8p @Pierre-Sassoulas
Update news fragment
12414c3 
Co-authored-by: Pierre Sassoulas <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 12414c3

@cdce8p cdce8p merged commit b970208 into pylint-dev:main Oct 13, 2025
44 checks passed
@cdce8p cdce8p deleted the match-bare-name-capture branch October 13, 2025 08:40
pylint-backport bot pushed a commit that referenced this pull request Oct 13, 2025
@cdce8p @pylint-backport
Fix false-positive for bare-name-capture-pattern (#10648)
be8d0ef 
(cherry picked from commit b970208)
@pylint-backport pylint-backport bot mentioned this pull request Oct 13, 2025
Merged
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Oct 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@mbyrnepr2 mbyrnepr2 mbyrnepr2 approved these changes

Assignees

No one assigned

Labels

backport maintenance/4.0.x False Positive 🦟 A message is emitted but nothing is wrong with the code Match case

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

bare-name-capture-pattern false positive with conditional case statement

3 participants

@cdce8p @Pierre-Sassoulas @mbyrnepr2