Avoid reporting useless-suppression on wrong-import-position (#5219) (#6347)

Co-authored-by: Pierre Sassoulas <[email protected]>

Author: timmartin

ChangeLog

@@ -234,6 +234,10 @@ Release date: TBA
 
   Closes #4525
 
+* Fix falsely issuing ``useless-suppression`` on the ``wrong-import-position`` checker.
+
+  Closes #5219
+
 * Fix false negative for ``no-member`` when attempting to assign an instance
   attribute to itself without any prior assignment.
 

doc/whatsnew/2.14.rst

@@ -245,6 +245,10 @@ Other Changes
 
   Closes #5205
 
+* Fix falsely issuing ``useless-suppression`` on the ``wrong-import-position`` checker.
+
+  Closes #5219
+
 * Fix false negative for ``no-member`` when attempting to assign an instance
   attribute to itself without any prior assignment.
 

pylint/checkers/imports.py

@@ -542,8 +542,6 @@ def leave_module(self, node: nodes.Module) -> None:
         self._first_non_import_node = None
 
     def compute_first_non_import_node(self, node):
-        if not self.linter.is_message_enabled("wrong-import-position", node.fromlineno):
-            return
         # if the node does not contain an import instruction, and if it is the
         # first node of the module, keep a track of it (all the import positions
         # of the module will be compared to the position of this first
@@ -584,8 +582,6 @@ def compute_first_non_import_node(self, node):
     ) = visit_comprehension = visit_expr = visit_if = compute_first_non_import_node
 
     def visit_functiondef(self, node: nodes.FunctionDef) -> None:
-        if not self.linter.is_message_enabled("wrong-import-position", node.fromlineno):
-            return
         # If it is the first non import instruction of the module, record it.
         if self._first_non_import_node:
             return
@@ -636,7 +632,16 @@ def _check_position(self, node):
         # if a first non-import instruction has already been encountered,
         # it means the import comes after it and therefore is not well placed
         if self._first_non_import_node:
-            self.add_message("wrong-import-position", node=node, args=node.as_string())
+            if self.linter.is_message_enabled(
+                "wrong-import-position", self._first_non_import_node.fromlineno
+            ):
+                self.add_message(
+                    "wrong-import-position", node=node, args=node.as_string()
+                )
+            else:
+                self.linter.add_ignored_message(
+                    "wrong-import-position", node.fromlineno, node
+                )
 
     def _record_import(self, node, importedmodnode):
         """Record the package `node` imports from."""

tests/functional/u/useless/useless_suppression.py

@@ -1,6 +1,6 @@
 """Tests for useless suppressions"""
 # pylint: enable=useless-suppression, line-too-long
-# pylint: disable=unused-import, wrong-import-order
+# pylint: disable=unused-import, wrong-import-order, wrong-import-position
 
 # False positive for wrong-import-order
 # Reported in https://github.com/PyCQA/pylint/issues/2366
@@ -10,3 +10,7 @@
 # False-positive for 'line-too-long'
 # Reported in https://github.com/PyCQA/pylint/issues/4212
 VAR = "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" # pylint: disable=line-too-long
+
+# False-positive for 'wrong-import-order'
+# Reported in https://github.com/PyCQA/pylint/issues/5219
+import os