Use namespace in PyLinter and tests

Author: DanielNoord

doc/test_messages_documentation.py

@@ -61,7 +61,7 @@ def __init__(self, test_file: Tuple[str, Path]) -> None:
         _test_reporter = FunctionalTestReporter()
 
         self._linter = PyLinter()
-        self._linter.config.persistent = 0
+        self._linter.namespace.persistent = 0
         checkers.initialize(self._linter)
 
         # Check if this message has a custom configuration file (e.g. for enabling optional checkers).

pylint/lint/pylinter.py

@@ -839,6 +839,12 @@ def _parse_error_mode(self) -> None:
 
         self.disable_noerror_messages()
         self.disable("miscellaneous")
+        self._arg_parser.parse_args(
+            ["--reports", "no", "--score", "no", "--persistent", "no"], self.namespace
+        )
+
+        # pylint: disable-next=fixme
+        # TODO: Potentially remove after 'set_option' has been refactored
         self.set_option("reports", False)
         self.set_option("persistent", False)
         self.set_option("score", False)
@@ -1060,7 +1066,7 @@ def check(self, files_or_modules: Union[Sequence[str], str]) -> None:
             files_or_modules = (files_or_modules,)  # type: ignore[assignment]
         if self.namespace.recursive:
             files_or_modules = tuple(self._discover_files(files_or_modules))
-        if self.config.from_stdin:
+        if self.namespace.from_stdin:
             if len(files_or_modules) != 1:
                 raise exceptions.InvalidArgsError(
                     "Missing filename required for --from-stdin"
@@ -1354,12 +1360,14 @@ def _check_astroid_module(
     def open(self):
         """Initialize counters."""
         self.stats = LinterStats()
-        MANAGER.always_load_extensions = self.config.unsafe_load_any_extension
-        MANAGER.max_inferable_values = self.config.limit_inference_results
-        MANAGER.extension_package_whitelist.update(self.config.extension_pkg_allow_list)
-        if self.config.extension_pkg_whitelist:
+        MANAGER.always_load_extensions = self.namespace.unsafe_load_any_extension
+        MANAGER.max_inferable_values = self.namespace.limit_inference_results
+        MANAGER.extension_package_whitelist.update(
+            self.namespace.extension_pkg_allow_list
+        )
+        if self.namespace.extension_pkg_whitelist:
             MANAGER.extension_package_whitelist.update(
-                self.config.extension_pkg_whitelist
+                self.namespace.extension_pkg_whitelist
             )
         self.stats.reset_message_count()
         self._ignore_paths = get_global_option(self, "ignore-paths")
@@ -1385,7 +1393,7 @@ def generate_reports(self):
                 self.reporter.display_reports(sect)
             score_value = self._report_evaluation()
             # save results if persistent run
-            if self.config.persistent:
+            if self.namespace.persistent:
                 config.save_results(self.stats, self.file_state.base_name)
         else:
             self.reporter.on_close(self.stats, LinterStats())
@@ -1424,7 +1432,7 @@ def _report_evaluation(self):
                 if pnote is not None:
                     msg += f" (previous run: {pnote:.2f}/10, {note - pnote:+.2f})"
 
-        if self.config.score:
+        if self.namespace.score:
             sect = report_nodes.EvaluationSection(msg)
             self.reporter.display_reports(sect)
         return note

pylint/reporters/text.py

@@ -172,7 +172,7 @@ def __init__(self, output: Optional[TextIO] = None) -> None:
 
     def on_set_current_module(self, module: str, filepath: Optional[str]) -> None:
         """Set the format template to be used and check for unrecognized arguments."""
-        template = str(self.linter.config.msg_template or self._template)
+        template = str(self.linter.namespace.msg_template or self._template)
 
         # Return early if the template is the same as the previous one
         if template == self._template:

pylint/testutils/global_test_linter.py

@@ -11,7 +11,7 @@ def create_test_linter():
     test_reporter = GenericTestReporter()
     linter_ = PyLinter()
     linter_.set_reporter(test_reporter)
-    linter_.config.persistent = 0
+    linter_.namespace.persistent = 0
     checkers.initialize(linter_)
     return linter_
 

pylint/testutils/lint_module_test.py

@@ -41,7 +41,7 @@ def __init__(
     ) -> None:
         _test_reporter = FunctionalTestReporter()
         self._linter = PyLinter()
-        self._linter.config.persistent = 0
+        self._linter.namespace.persistent = 0
         checkers.initialize(self._linter)
 
         # See if test has its own .rc file, if so we use that one

tests/lint/unittest_lint.py

@@ -732,7 +732,7 @@ def test_custom_should_analyze_file() -> None:
         reporter = testutils.GenericTestReporter()
         linter = _CustomPyLinter()
         linter.namespace.jobs = jobs
-        linter.config.persistent = 0
+        linter.namespace.persistent = 0
         linter.open()
         linter.set_reporter(reporter)
 
@@ -765,7 +765,7 @@ def test_multiprocessing(jobs: int) -> None:
     reporter = testutils.GenericTestReporter()
     linter = PyLinter()
     linter.namespace.jobs = jobs
-    linter.config.persistent = 0
+    linter.namespace.persistent = 0
     linter.open()
     linter.set_reporter(reporter)
 

tests/unittest_reporters_json.py

@@ -79,8 +79,8 @@ def get_linter_result(score: bool, message: Dict[str, Any]) -> List[Dict[str, An
     reporter = JSONReporter(output)
     linter = PyLinter(reporter=reporter)
     checkers.initialize(linter)
-    linter.config.persistent = 0
-    linter.config.score = score
+    linter.namespace.persistent = 0
+    linter.namespace.score = score
     linter.open()
     linter.set_current_module("0123")
     linter.add_message(

tests/unittest_reporting.py

@@ -36,7 +36,7 @@ def disable():
 def test_template_option(linter):
     output = StringIO()
     linter.reporter.out = output
-    linter.set_option("msg-template", "{msg_id}:{line:03d}")
+    linter.namespace.msg_template = "{msg_id}:{line:03d}"
     linter.open()
     linter.set_current_module("0123")
     linter.add_message("C0301", line=1, args=(1, 2))
@@ -62,9 +62,8 @@ def test_template_option_end_line(linter) -> None:
     """Test the msg-template option with end_line and end_column."""
     output = StringIO()
     linter.reporter.out = output
-    linter.set_option(
-        "msg-template",
-        "{path}:{line}:{column}:{end_line}:{end_column}: {msg_id}: {msg} ({symbol})",
+    linter.namespace.msg_template = (
+        "{path}:{line}:{column}:{end_line}:{end_column}: {msg_id}: {msg} ({symbol})"
     )
     linter.open()
     linter.set_current_module("my_mod")
@@ -85,9 +84,8 @@ def test_template_option_non_existing(linter) -> None:
     """
     output = StringIO()
     linter.reporter.out = output
-    linter.set_option(
-        "msg-template",
-        "{path}:{line}:{a_new_option}:({a_second_new_option:03d})",
+    linter.namespace.msg_template = (
+        "{path}:{line}:{a_new_option}:({a_second_new_option:03d})"
     )
     linter.open()
     with pytest.warns(UserWarning) as records:
@@ -136,7 +134,7 @@ def test_parseable_output_regression():
         linter = PyLinter(reporter=ParseableTextReporter())
 
     checkers.initialize(linter)
-    linter.config.persistent = 0
+    linter.namespace.persistent = 0
     linter.reporter.out = output
     linter.set_option("output-format", "parseable")
     linter.open()