Fix FP, add more test cases

Got to carried away deleting code and deleted the most important
comparison to see if what is yielded are the items iterated on. Also
added more cases to the test file.

Author: crazybolillo

pylint/checkers/refactoring/refactoring_checker.py

@@ -1137,6 +1137,9 @@ def visit_yield(self, node: nodes.Yield) -> None:
         if not isinstance(parent, nodes.For) or len(parent.body) != 1:
             return
 
+        if parent.target.name != node.value.name:
+            return
+
         self.add_message("use-yield-from", node.lineno, node, confidence=HIGH)
 
     @staticmethod

tests/functional/u/use/use_yield_from.py

@@ -1,8 +1,8 @@
-# pylint: disable=missing-docstring, import-error
-
+# pylint: disable=missing-docstring, import-error, yield-outside-function
 import factory
 from magic import shazam, turbogen
 
+yield 1
 
 def bad(generator):
     for item in generator:
@@ -37,3 +37,11 @@ def yield_attr_nested():
 def yield_expr():
     for item in [1, 2, 3]:
         yield item  # [use-yield-from]
+
+
+def for_else_yield(gen, something):
+    for item in gen():
+        if shazam(item):
+            break
+    else:
+        yield something