*args and **kwargs in find_argname, doc and style fixes, changelog

* find_argname now works when requesting vararg or kwargs.
* Fixed some annotations in code and documentation.
* Added changelog.

Author: crazybolillo

ChangeLog

@@ -6,6 +6,11 @@ What's New in astroid 3.0.0?
 =============================
 Release date: TBA
 
+* Return all existing arguments when calling ``Arguments.arguments()``. This also means ``find_argname`` will now search
+  use the whole list of arguments for its search.
+
+  Closes #2213
+
 * Add support for Python 3.12, including PEP 695 type parameter syntax.
 
   Closes #2201

astroid/arguments.py

@@ -181,7 +181,13 @@ def infer_argument(
 
         positional = self.positional_arguments[: len(funcnode.args.args)]
         vararg = self.positional_arguments[len(funcnode.args.args) :]
-        argindex = funcnode.args.find_argname(name)[0]
+
+        # preserving previous behavior, when vararg and kwarg were not included in find_argname results
+        if name in [funcnode.args.vararg, funcnode.args.kwarg]:
+            argindex = None
+        else:
+            argindex = funcnode.args.find_argname(name)[0]
+
         kwonlyargs = {arg.name for arg in funcnode.args.kwonlyargs}
         kwargs = {
             key: value

astroid/nodes/node_classes.py

@@ -706,19 +706,19 @@ class Arguments(
     kwargannotation: NodeNG | None
     """The type annotation for the variable length keyword arguments."""
 
-    vararg_node: NodeNG | None
+    vararg_node: AssignName | None
     """The node for variable length arguments"""
 
-    kwarg_node: NodeNG | None
-    """The node for keyword arguments"""
+    kwarg_node: AssignName | None
+    """The node for variable keyword arguments"""
 
     def __init__(
         self,
         vararg: str | None,
         kwarg: str | None,
         parent: NodeNG,
-        vararg_node: NodeNG | None = None,
-        kwarg_node: NodeNG | None = None,
+        vararg_node: AssignName | None = None,
+        kwarg_node: AssignName | None = None,
     ) -> None:
         """Almost all attributes can be None for living objects where introspection failed."""
         super().__init__(
@@ -803,7 +803,7 @@ def arguments(self):
         * Positional arguments
         * Keyword arguments
         * Variable arguments (.e.g *args)
-        * Keyword only arguments (e.g **kwargs)
+        * Variable keyword arguments (e.g **kwargs)
         """
         retval = list(itertools.chain((self.posonlyargs or ()), (self.args or ())))
         if self.vararg_node:
@@ -970,11 +970,7 @@ def is_argument(self, name) -> bool:
             return True
         if name == self.kwarg:
             return True
-        return (
-            self.find_argname(name)[1] is not None
-            or self.kwonlyargs
-            and _find_arg(name, self.kwonlyargs)[1] is not None
-        )
+        return self.find_argname(name)[1] is not None
 
     def find_argname(self, argname, rec=DEPRECATED_ARGUMENT_DEFAULT):
         """Get the index and :class:`AssignName` node for given name.
@@ -993,7 +989,7 @@ def find_argname(self, argname, rec=DEPRECATED_ARGUMENT_DEFAULT):
             )
         if self.arguments:
             index, argument = _find_arg(argname, self.arguments)
-            if argument and argument.name not in [self.vararg, self.kwarg]:
+            if argument:
                 return index, argument
         return None, None