From bcb1b9b8e34c5a7f6d017d3c098021262f7546bc Mon Sep 17 00:00:00 2001 From: Maximilian Roos Date: Tue, 30 Apr 2024 12:24:34 -0700 Subject: [PATCH 1/2] Skip flaky `test_open_mfdataset_manyfiles` test Don't just xfail, and not only on windows, since it can crash the worked --- xarray/tests/test_backends.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xarray/tests/test_backends.py b/xarray/tests/test_backends.py index fdf181b583a..68f63e3c9a0 100644 --- a/xarray/tests/test_backends.py +++ b/xarray/tests/test_backends.py @@ -3813,11 +3813,9 @@ def skip_if_not_engine(engine): pytest.importorskip(engine) -# Flaky test. Very open to contributions on fixing this @requires_dask @pytest.mark.filterwarnings("ignore:use make_scale(name) instead") -@pytest.mark.xfail(reason="Flaky test. Very open to contributions on fixing this") -@pytest.mark.skipif(ON_WINDOWS, reason="Skipping on Windows") +@pytest.mark.skip(reason="Flaky test which can cause the worker to crash (so don't xfail). Very open to contributions fixing this") def test_open_mfdataset_manyfiles( readengine, nfiles, parallel, chunks, file_cache_maxsize ): From 1463e6fa430a0f8322d524cb2c3dfaf926f5faf2 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 30 Apr 2024 19:25:21 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- xarray/tests/test_backends.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xarray/tests/test_backends.py b/xarray/tests/test_backends.py index 68f63e3c9a0..8564191a0f7 100644 --- a/xarray/tests/test_backends.py +++ b/xarray/tests/test_backends.py @@ -3815,7 +3815,9 @@ def skip_if_not_engine(engine): @requires_dask @pytest.mark.filterwarnings("ignore:use make_scale(name) instead") -@pytest.mark.skip(reason="Flaky test which can cause the worker to crash (so don't xfail). Very open to contributions fixing this") +@pytest.mark.skip( + reason="Flaky test which can cause the worker to crash (so don't xfail). Very open to contributions fixing this" +) def test_open_mfdataset_manyfiles( readengine, nfiles, parallel, chunks, file_cache_maxsize ):