From ce89ec20bbc37d27e5e90f2723c1647fe17a34fd Mon Sep 17 00:00:00 2001 From: Maximilian Roos Date: Thu, 8 Aug 2019 18:18:15 -0400 Subject: [PATCH] update instructions --- doc/contributing.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/contributing.rst b/doc/contributing.rst index 14ecb65f295..72e4f07b778 100644 --- a/doc/contributing.rst +++ b/doc/contributing.rst @@ -389,14 +389,14 @@ each time you commit changes. You can skip these checks with conflicts. Because they have had limited testing, please reach out to the core devs on your pull request if you face any issues, and we'll help with the merge: - - Merge the commit on master prior to the `black` commit into your branch - `git merge f172c673`. Any conflicts are real conflicts and require resolving - - Apply `black .` to your branch and commit - # TODO: insert after the black commit is on master - - Merge master at the `black` commit, resolving in favor of 'our' changes: - `git merge [master-at-black-commit] -X ours`. You shouldn't have any merge conflicts - - Merge current master `git merge master`; any conflicts here are real and - again require resolving + - Merge the commit on master prior to the ``black`` commit into your branch + ``git merge f172c673``. If you have conflicts here, resolve and commit. + - Apply ``black .`` to your branch and commit ``git commit -am "black"`` + - Apply a patch of other changes we made on that commit: ``curl https://gist.githubusercontent.com/max-sixty/3cceb8472ed4ea806353999ca43aed52/raw/03cbee4e386156bddb61acaa250c0bfc726f596d/xarray%2520black%2520diff | git apply -`` + - Commit (``git commit -am "black2"``) + - Merge master at the ``black`` commit, resolving in favor of 'our' changes: + ``git merge d089df38 -X ours``. You shouldn't have any merge conflicts + - Merge current master ``git merge master``; resolve and commit any conflicts Backwards Compatibility ~~~~~~~~~~~~~~~~~~~~~~~