Skip to content

Fix Zarr 'number of requests' test #10492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

Fix Zarr 'number of requests' test #10492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
325eac2
Revert "Downgrade zarr requests performance expectations for zarr 3.0…
ianhi Jul 2, 2025
a47b0cd
test: rescope fixture to prevent state leakage
ianhi Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xarray/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,6 @@ def simple_datatree(create_test_datatree):
return create_test_datatree()


@pytest.fixture(scope="module", params=["s", "ms", "us", "ns"])
@pytest.fixture(params=["s", "ms", "us", "ns"])
def time_unit(request):
return request.param
16 changes: 8 additions & 8 deletions xarray/tests/test_backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3545,8 +3545,8 @@ def test_append(self) -> None:
if has_zarr_v3:
# TODO: verify these
expected = {
"set": 16,
"get": 8, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
"set": 5,
"get": 4,
"list_dir": 2,
"list_prefix": 1,
}
Expand All @@ -3570,8 +3570,8 @@ def test_append(self) -> None:
# 6057128b: {'iter': 5, 'contains': 2, 'setitem': 5, 'getitem': 10, "listdir": 5, "list_prefix": 0}
if has_zarr_v3:
expected = {
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
"set": 4,
"get": 9, # TODO: fixme upstream (should be 8)
"list_dir": 2, # TODO: fixme upstream (should be 2)
"list_prefix": 0,
}
Expand All @@ -3593,8 +3593,8 @@ def test_append(self) -> None:

if has_zarr_v3:
expected = {
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
"set": 4,
"get": 9, # TODO: fixme upstream (should be 8)
"list_dir": 2, # TODO: fixme upstream (should be 2)
"list_prefix": 0,
}
Expand Down Expand Up @@ -3627,8 +3627,8 @@ def test_region_write(self) -> None:
with self.create_zarr_target() as store:
if has_zarr_v3:
expected = {
"set": 16,
"get": 8, # TODO: fixme upstream (should be 2), see https://github.com/zarr-developers/zarr-python/issues/3199
"set": 5,
"get": 2,
"list_dir": 2,
"list_prefix": 4,
}
Expand Down
Loading