tweak line continuation in cpuinfo (py37 win problem) #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note the 3 s (ssse3) vs 2 s (sse3) ! I have not idea what ssse3 means, so I don't know if it makes any sense, but at least it is probably not always False. |
|
I think the extra |
Contributor
Author
|
ah! Sorry about that. I'll remove that part of the PR. |
msarahan
force-pushed
the
line_continuation
branch
from
b282fe5 to
f372dcd
Compare
Contributor
Author
|
Reverted and left a comment there for future people like me |
msarahan
force-pushed
the
line_continuation
branch
from
72b6f3f to
f372dcd
Compare
Member
|
The file changes look fine to me. Not sure why Appveyor is showing a failure here since it doesn't on their own site. This FYI I have looked at putting in workhorsey's |
Member
|
Merging, since there have been no further comments. I do think it's sensible that we wait for 3.7.1 to formally support Python 3.7 though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These line continuation characters were tripping up python 3.7 on Windows (only this platform - mac and linux, as well as all other Python versions on Windows were fine. Go figure.
Also, this particular line seemed fishy:
isn't that always false, by definition, because they can't both be true? I looked it up online, and nocona has sse3, so I tried to adjust the logic accordingly (keep just self.has_sse3).