Merge pull request #121 from konstruktoid/shellcheck

shellcheck create_dummy_box.sh

Author: konstruktoid

tests/tools/create_dummy_box.sh

@@ -2,21 +2,21 @@
 set -euxo pipefail
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+PROVIDER="$1"
+TMPDIR="$(mktemp -d)"
 
 if [ $# -ne 1 ]; then
 	echo "Missing provider" >&2
 	exit 1
 fi
 
-if [ -f "$DIR/dummy.box" ]; then
+if [ -f "${DIR}/dummy-${PROVIDER}.box" ]; then
 	echo "Box already created"
 	exit 0
 fi
 
-PROVIDER="$1"
-TMPDIR=`mktemp -d`
-cd "$TMPDIR"
-echo "{ \"provider\": \"$PROVIDER\"}" > metadata.json
-tar czf "$DIR/dummy-$PROVIDER.box" .
-cd "$DIR"
-rm -rf "$TMPDIR"
+cd "${TMPDIR}" || exit 1
+echo "{ \"provider\": \"${PROVIDER}\"}" > metadata.json
+tar czf "${DIR}/dummy-${PROVIDER}.box" .
+cd "${DIR}" || exit 1
+rm -rvf "${TMPDIR}"