use subprocess and assert the return code

Signed-off-by: Thomas Sjögren <[email protected]>

Author: konstruktoid

tests/test_vagrant.py

@@ -286,8 +286,9 @@ def test_vm_lifecycle(vm_dir):
 def test_valid_config(vm_dir):
     v = vagrant.Vagrant(vm_dir)
     v.up()
-    output = v.validate()
-    assert output.strip() == "Vagrantfile validated successfully."
+    validation = v.validate(vm_dir)
+
+    assert validation.returncode == 0
 
 
 def test_vm_config(vm_dir):

vagrant/__init__.py

@@ -876,12 +876,19 @@ def plugin_list(self):
         output = self._run_vagrant_command(["plugin", "list", "--machine-readable"])
         return self._parse_plugin_list(output)
 
-    def validate(self):
+    def validate(self, directory):
         """
         This command validates present Vagrantfile.
         """
-        output = self._run_vagrant_command(["validate"])
-        return output
+        validate = subprocess.run(
+            ["vagrant", "validate"],
+            cwd=directory,
+            check=True,
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE,
+        )
+
+        return validate
 
     def _parse_plugin_list(self, output):
         """