Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Commit 68c3374

Browse files
committed
raise exception if NV writing failed
1 parent f2db523 commit 68c3374

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

esp32/mods/modpycom.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -891,7 +891,7 @@ STATIC mp_obj_t mod_pycom_sigfox_info (size_t n_args, const mp_obj_t *pos_args,
891891

892892
ret_val = config_set_sigfox_id(tmp_array);
893893
if (ret_val == false) {
894-
return mp_const_false;
894+
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Failed to write id"));
895895
}
896896
} else {
897897
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Use force option to overwrite existing id!"));
@@ -922,7 +922,7 @@ STATIC mp_obj_t mod_pycom_sigfox_info (size_t n_args, const mp_obj_t *pos_args,
922922

923923
ret_val = config_set_sigfox_pac(tmp_array);
924924
if (ret_val == false) {
925-
return mp_const_false;
925+
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Failed to write pac"));
926926
}
927927
} else {
928928
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Use force option to overwrite existing pac!"));
@@ -953,7 +953,7 @@ STATIC mp_obj_t mod_pycom_sigfox_info (size_t n_args, const mp_obj_t *pos_args,
953953

954954
ret_val = config_set_sigfox_public_key(tmp_array);
955955
if (ret_val == false) {
956-
return mp_const_false;
956+
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Failed to write public key"));
957957
}
958958
} else {
959959
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Use force option to overwrite existing public key!"));
@@ -985,7 +985,7 @@ STATIC mp_obj_t mod_pycom_sigfox_info (size_t n_args, const mp_obj_t *pos_args,
985985

986986
ret_val = config_set_sigfox_private_key(tmp_array);
987987
if (ret_val == false) {
988-
return mp_const_false;
988+
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Failed to write private key"));
989989
}
990990
} else {
991991
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "Use force option to overwrite existing private key!"));

0 commit comments

Comments
 (0)