Fix multi-context new Python linking mode #4401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow CMake find_package() from multiple directories. pybind#4400
Skylion007
approved these changes
Dec 12, 2022
Collaborator
Skylion007
left a comment
Skylion007
left a comment
There was a problem hiding this comment.
Looks good to me, but this is really @henryiii's domain.
henryiii
approved these changes
Dec 13, 2022
Collaborator
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
Seems fine. Have you verified it does work in this way?
Contributor
Author
It seems to be working for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow CMake find_package() from multiple directories.
Fixes #4400
Suggested changelog entry:
* Allow calling ``find_package(pybind11 CONFIG)`` multiple times from separate directories in the same CMake project and properly link Python (new mode).