Fix casts to void* #4273
Closed
Fix casts to void* #4273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Oh ... did you close this because you saw #4274? |
Collaborator
|
I liked the way this just added to an existing tests (+ it works on clang since there's not a new class to complain about missing constructors about). |
Collaborator
|
Outside.
Sounds good to me: take fix from 4274 and the test from here.
I'm not able to do that before tomorrow.
…On Fri, Oct 21, 2022 at 20:50 Henry Schreiner ***@***.***> wrote:
I liked the way this just added to an existing tests (+ it works on clang
since there's not a new class to complain about missing constructors about).
—
Reply to this email directly, view it on GitHub
<#4273 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFUZAGUZEY7SY5QPBYNS2DWENP7XANCNFSM6AAAAAARLU2X64>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current code is broken for safe casts to void* as those are incorrectly converted to casts to void. This fixes the problem.
Fixes #4117, needed for #4125