Skip to content

Conversation

@Skylion007
Copy link
Collaborator

Description

  • I was looking through the include cast and noticed we could steal the arg_v.value for the copied arg in the process list. This should remove one inc-ref / dec-ref from py::object and therefore potentially speed up the processing of a function with lots of specified arg_v values.

Suggested changelog entry:

* chore: optimize unpacking_collector when processing arg_v arguments.

@Skylion007 Skylion007 requested review from henryiii and rwgk October 6, 2022 15:02
@Skylion007 Skylion007 merged commit 864ed11 into pybind:master Oct 6, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Oct 6, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants