addl unit tests for PR #3970 #3977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
force-pushed
the
perf_attr-key-reference-stealing
branch
2 times, most recently
from
5dc2f31 to
bc61683
Compare
rwgk
changed the title
leslinice
approved these changes
May 28, 2022
rwgk
force-pushed
the
perf_attr-key-reference-stealing
branch
from
e7d5c74 to
5fdfcdd
Compare
rwgk
changed the title
Skylion007
approved these changes
May 31, 2022
Collaborator
Skylion007
left a comment
Skylion007
left a comment
There was a problem hiding this comment.
@rwgk Looks good to me.
Collaborator
Author
Collaborator
|
@rwgk Sounds good. Feel free to strip out the changes and merge. |
…atforms reach the PYBIND11_HANDLE_REF_DEBUG code, with and without threads.
for more information, see https://pre-commit.ci
rwgk
force-pushed
the
perf_attr-key-reference-stealing
branch
from
25c60cc to
0c63a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution to / preparation for PR #3970. The
inc_refsline in test_pytypes.py will need to be adjusted, which will effectively document the behavior change.Full test coverage for all newly added functions, sensitive to the change from copy to move behavior.
I went through top-to-bottom in this copy of pytypes.h, undoing the changes under PR #3970 one-by-one, and verifying that the new test fails.
The newly introduced
PYBIND11_HANDLE_REF_DEBUGmight be useful for unit-testing other move-instead-of-copy optimizations. The main goal is to ensure that such optimizations do not accidentally get undone.Suggested changelog entry: