Skip to content

Conversation

@henryiii
Copy link
Collaborator

@henryiii henryiii commented Aug 17, 2020

Followup to #2377, moves contributing.

Also modernizes some of README, including adding a prominent link to the contributing document. The most notable point is the update to the PyPy version - currently we test PyPy/PyPy3 7.3. If we state an earlier version here, we should probably test it. Open to doing something different though.

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for updating the README!

@YannickJadoul
Copy link
Collaborator

The most notable point is the update to the PyPy version - currently we test PyPy/PyPy3 7.3.

Happy with that, but I feel this is something that should pass @wjakob's eye, since it's changing one of the promises of pybind11.

@henryiii
Copy link
Collaborator Author

Agreed. I don't like promising anything we don't test, so if we promise earlier, we should add a test.

@henryiii henryiii added the docs Docs or GitHub info label Aug 18, 2020
@henryiii
Copy link
Collaborator Author

I've made the statement less promisy and more truthful (tested on 7.3) so this can move forward. @wjakob has already signed off on the CONTRIBUTING move, which was the focus of this PR.

@YannickJadoul
Copy link
Collaborator

I'd still like an answer to the minimal PyPy version we're supporting. We could potentially get rid of a bunch of code, if we pick a sane, modern, by-PyPy-supported version.

But that shouldn't stop this PR, indeed. Maybe create an issue?

@henryiii henryiii merged commit f31df73 into pybind:master Aug 20, 2020
@henryiii henryiii deleted the docs/contrib2 branch August 20, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Docs or GitHub info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants