Skip to content

Conversation

@bstaletic
Copy link
Collaborator

The FTP server pointed to by the old URL doesn't exist any more. Instead, this PR uses the upstream Doxygen archive URL. Though I'm not sure how long will the archive stay there after they release a new version.

@YannickJadoul
Copy link
Collaborator

YannickJadoul commented Jan 2, 2019

Any idea how we could fix the remaining error?

$PY_CMD -m sphinx -W -b html docs docs/.build
Running Sphinx v1.8.2
making output directory...
doxygen: error while loading shared libraries: libclang.so.6: cannot open shared object file: No such file or directory
doxygen: error while loading shared libraries: libclang.so.6: cannot open shared object file: No such file or directory
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 29 source files that are out of date
updating environment: 29 added, 0 changed, 0 removed
reading sources... [100%] upgrade                                               
Warning, treated as error:
/home/travis/build/pybind/pybind11/docs/reference.rst:17:doxygendefine: Cannot find file: /home/travis/build/pybind/pybind11/docs/.build/doxygenxml/index.xml
The command "$PY_CMD -m sphinx -W -b html docs docs/.build" exited with 2.

@YannickJadoul
Copy link
Collaborator

Any idea how we could fix the remaining error?

Actually, I just checked, and maybe updating to 1.8.15 might help? I'm reading now next to this download: "Compiled using Ubuntu 16.04 with kernel 4.4.0 and gcc 5.4.0 and statically linked again libclang."
Given that the download is also ~ 40 MB compared to ~ 20 MB for 1.8.14, I'd estimate there a chance that this wasn't the case before, causing the error above.

@bstaletic
Copy link
Collaborator Author

When I was submitting the PR, there was no 1.8.15. Let me try updating it.

@bstaletic bstaletic force-pushed the doxygen_url branch 6 times, most recently from 181edcf to ab04908 Compare January 2, 2019 15:26
@YannickJadoul
Copy link
Collaborator

I've tracked down the MSVC issue. This commit should fix it: YannickJadoul@1f23277

@bstaletic
Copy link
Collaborator Author

@YannickJadoul Thanks for that. Since it's just a using declaration, I think it's fine to let all compilers use what works for MSVC, since it will be compiled to the same assembly.

@bstaletic bstaletic changed the title [READY] Use upstream Doxygen archive - fixes Travis [WIP] Use upstream Doxygen archive - fixes Travis Jan 3, 2019
@wjakob
Copy link
Member

wjakob commented Jan 3, 2019

This looks good, but can you split this into two separate PRs? (after all, these are two completely different issues)

@bstaletic
Copy link
Collaborator Author

I can split into two PR, but I thought it's better to fix CI in one go, than to have two PRs each fixing one of the CI providers.

@bstaletic bstaletic changed the title [WIP] Use upstream Doxygen archive - fixes Travis [READY] Use upstream Doxygen archive - fixes Travis Jan 3, 2019
@wjakob
Copy link
Member

wjakob commented Jan 3, 2019

At least having two commits would be helpful (with one addressing documentation, and the other for the internal MSVC segfault)

@bstaletic
Copy link
Collaborator Author

Alright, I've split it into two commits.

@wjakob
Copy link
Member

wjakob commented Jan 3, 2019

Ok, thanks!

@wjakob wjakob merged commit 0ca6867 into pybind:master Jan 3, 2019
@bstaletic bstaletic deleted the doxygen_url branch January 3, 2019 11:08
@wjakob
Copy link
Member

wjakob commented Jan 3, 2019

The CI tests fail after merging this PR: https://ci.appveyor.com/project/wjakob/pybind11/builds/21354272/job/xk1wx8hh7f1050p0

@YannickJadoul
Copy link
Collaborator

Huh, that's weird. @martinRenou's #1641 was rebased onto this master is is now succeeding. And the VS 2015 were green before; this PR was only needed to fix the VS 2017 update.
Could this be a fluke in this particular AppVeyor run?

@YannickJadoul
Copy link
Collaborator

Now a different test is failing: https://ci.appveyor.com/project/wjakob/pybind11/builds/21358020
And looking at the history, even different tests are failing there. So is there some kind of race condition triggered by this test_gil_scoped ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants