-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[READY] Use upstream Doxygen archive - fixes Travis #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any idea how we could fix the remaining error? |
Actually, I just checked, and maybe updating to 1.8.15 might help? I'm reading now next to this download: "Compiled using Ubuntu 16.04 with kernel 4.4.0 and gcc 5.4.0 and statically linked again libclang." |
|
When I was submitting the PR, there was no 1.8.15. Let me try updating it. |
181edcf to
ab04908
Compare
|
I've tracked down the MSVC issue. This commit should fix it: YannickJadoul@1f23277 |
|
@YannickJadoul Thanks for that. Since it's just a |
|
This looks good, but can you split this into two separate PRs? (after all, these are two completely different issues) |
|
I can split into two PR, but I thought it's better to fix CI in one go, than to have two PRs each fixing one of the CI providers. |
|
At least having two commits would be helpful (with one addressing documentation, and the other for the internal MSVC segfault) |
|
Alright, I've split it into two commits. |
|
Ok, thanks! |
|
The CI tests fail after merging this PR: https://ci.appveyor.com/project/wjakob/pybind11/builds/21354272/job/xk1wx8hh7f1050p0 |
|
Huh, that's weird. @martinRenou's #1641 was rebased onto this master is is now succeeding. And the VS 2015 were green before; this PR was only needed to fix the VS 2017 update. |
|
Now a different test is failing: https://ci.appveyor.com/project/wjakob/pybind11/builds/21358020 |
The FTP server pointed to by the old URL doesn't exist any more. Instead, this PR uses the upstream Doxygen archive URL. Though I'm not sure how long will the archive stay there after they release a new version.