Add 2 missing throw error_already_set(); (#4863)

rwgk · web-flow · commit f468b0707ea8 · 2023-09-27T09:55:49.000-07:00
Fixes oversights in PR #4570.
diff --git a/include/pybind11/detail/internals.h b/include/pybind11/detail/internals.h
@@ -451,6 +451,7 @@ inline object get_python_state_dict() {
 #endif
     if (!state_dict) {
         raise_from(PyExc_SystemError, "pybind11::detail::get_python_state_dict() FAILED");
+        throw error_already_set();
     }
     return state_dict;
 }
@@ -463,6 +464,7 @@ inline internals **get_internals_pp_from_capsule(handle obj) {
     void *raw_ptr = PyCapsule_GetPointer(obj.ptr(), /*name=*/nullptr);
     if (raw_ptr == nullptr) {
         raise_from(PyExc_SystemError, "pybind11::detail::get_internals_pp_from_capsule() FAILED");
+        throw error_already_set();
     }
     return static_cast<internals **>(raw_ptr);
 }

Original file line number	Diff line number	Diff line change
`@@ -451,6 +451,7 @@ inline object get_python_state_dict() {`
`451`	`451`	`#endif`
`452`	`452`	`if (!state_dict) {`
`453`	`453`	`raise_from(PyExc_SystemError, "pybind11::detail::get_python_state_dict() FAILED");`
	`454`	`+ throw error_already_set();`
`454`	`455`	`}`
`455`	`456`	`return state_dict;`
`456`	`457`	`}`
`@@ -463,6 +464,7 @@ inline internals **get_internals_pp_from_capsule(handle obj) {`
`463`	`464`	`void raw_ptr = PyCapsule_GetPointer(obj.ptr(), /name=*/nullptr);`
`464`	`465`	`if (raw_ptr == nullptr) {`
`465`	`466`	`raise_from(PyExc_SystemError, "pybind11::detail::get_internals_pp_from_capsule() FAILED");`
	`467`	`+ throw error_already_set();`
`466`	`468`	`}`
`467`	`469`	`return static_cast<internals **>(raw_ptr);`
`468`	`470`	`}`