refine

Author: oraluben

tests/pybind11_cross_module_tests.cpp

@@ -34,7 +34,7 @@ PYBIND11_MODULE(pybind11_cross_module_tests, m) {
     py::register_exception_translator([](std::exception_ptr p) {
       try {
           if (p) std::rethrow_exception(p);
-      } catch (const tmp_e &e) {
+      } catch (const shared_exception &e) {
           PyErr_SetString(PyExc_KeyError, e.what());
       }
     });

tests/test_exceptions.cpp

@@ -229,5 +229,5 @@ TEST_SUBMODULE(exceptions, m) {
     // Test repr that cannot be displayed
     m.def("simple_bool_passthrough", [](bool x) {return x;});
 
-    m.def("throw_", []() { throw tmp_e(); });
+    m.def("throw_should_be_translated_to_key_error", []() { throw shared_exception(); });
 }

tests/test_exceptions.h

@@ -4,9 +4,9 @@
 
 // shared exceptions for cross_module_tests
 
-class PYBIND11_EXPORT tmp_e : public pybind11::builtin_exception {
+class PYBIND11_EXPORT shared_exception : public pybind11::builtin_exception {
 public:
     using builtin_exception::builtin_exception;
-    explicit tmp_e() : tmp_e("") {}
+    explicit shared_exception() : shared_exception("") {}
     void set_error() const override { PyErr_SetString(PyExc_RuntimeError, what()); }
 };

tests/test_exceptions.py

@@ -44,7 +44,8 @@ def test_cross_module_exceptions():
         cm.throw_stop_iteration()
 
     with pytest.raises(KeyError) as excinfo:
-        m.throw_()
+        # translator registered in cross_module_tests
+        m.throw_should_be_translated_to_key_error()
 
 
 def test_python_call_in_catch():