Skip to content

Commit b47e690

Browse files
committed
Try running cmake --build . --target cpptest on all platforms (standard job).
1 parent 16edc01 commit b47e690

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,7 @@ jobs:
133133
run: cmake --build . --target pytest -j 2
134134

135135
- name: C++11 tests
136-
# TODO: Figure out how to load the DLL on Python 3.8+
137-
if: "!(runner.os == 'Windows' && (matrix.python == 3.8 || matrix.python == 3.9 || matrix.python == '3.10' || matrix.python == '3.11' || matrix.python == 'pypy-3.8'))"
138-
run: cmake --build . --target cpptest -j 2
136+
run: cmake --build . --target cpptest -j 2
139137

140138
- name: Interface test C++11
141139
run: cmake --build . --target test_cmake_build
@@ -164,8 +162,6 @@ jobs:
164162
run: cmake --build build2 --target pytest
165163

166164
- name: C++ tests
167-
# TODO: Figure out how to load the DLL on Python 3.8+
168-
if: "!(runner.os == 'Windows' && (matrix.python == 3.8 || matrix.python == 3.9 || matrix.python == '3.10' || matrix.python == '3.11' || matrix.python == 'pypy-3.8'))"
169165
run: cmake --build build2 --target cpptest
170166

171167
# Third build - C++17 mode with unstable ABI

0 commit comments

Comments
 (0)