Adding tests

Author: henryiii

include/pybind11/attr.h

@@ -184,7 +184,7 @@ struct function_record {
 
     /// True if this is a method
     bool is_method : 1;
-    
+
     /// True if this function takes priority when defined in overload resolution
     bool is_priority_overload : 1;
 

include/pybind11/pybind11.h

@@ -340,7 +340,7 @@ class cpp_function : public function {
                         std::string(pybind11::str(rec->scope.attr("__name__"))) + "." + std::string(rec->name) + signature
                     #endif
                 );
-            
+
             if (rec->is_priority_overload) {
                 // Beginning of chain
                 chain_start = rec;

tests/test_methods_and_attributes.cpp

@@ -327,6 +327,18 @@ TEST_SUBMODULE(methods_and_attributes, m) {
     py::class_<MetaclassOverride>(m, "MetaclassOverride", py::metaclass((PyObject *) &PyType_Type))
         .def_property_readonly_static("readonly", [](py::object) { return 1; });
 
+    // test_overload_ordering
+    struct OverloadOrder {
+        int value;
+        OverloadOrder(int value) : value(value) {}
+    };
+    py::class_<OverloadOrder>(m, "OverloadOrder")
+        .def(py::init([](std::string) { return new OverloadOrder{1};}))
+        .def(py::init([](std::string) { return new OverloadOrder{2};}))
+        .def(py::init([](int) { return new OverloadOrder{1};}))
+        .def(py::init([](int) { return new OverloadOrder{2};}), py::priority_overload())
+        .def_readonly("value", &OverloadOrder::value);
+
 #if !defined(PYPY_VERSION)
     // test_dynamic_attributes
     class DynamicClass {

tests/test_methods_and_attributes.py

@@ -474,3 +474,11 @@ def test_custom_caster_destruction():
 
     # Make sure we still only have the original object (from ..._no_destroy()) alive:
     assert cstats.alive() == 1
+
+
+def test_overload_order_normal():
+    assert m.OverloadOrder("this").value == 1
+
+
+def test_overload_order_priority():
+    assert m.OverloadOrder(0).value == 2