fix: PGI compiler fix

Author: henryiii

include/pybind11/detail/common.h

@@ -501,8 +501,9 @@ template <bool... Bs> using select_indices = typename select_indices_impl<index_
 template <bool B> using bool_constant = std::integral_constant<bool, B>;
 template <typename T> struct negation : bool_constant<!T::value> { };
 
-template <typename...> struct void_t_impl { using type = void; };
-template <typename... Ts> using void_t = typename void_t_impl<Ts...>::type;
+template <typename... >
+using void_t = void;
+
 
 /// Compile-time all/any/none of that check the boolean value of all template types
 #if defined(__cpp_fold_expressions) && !(defined(_MSC_VER) && (_MSC_VER < 1916))

tests/test_factory_constructors.cpp

@@ -11,6 +11,7 @@
 #include "pybind11_tests.h"
 #include "constructor_stats.h"
 #include <cmath>
+#include <new>
 
 // Classes for testing python construction via C++ factory function:
 // Not publicly constructible, copyable, or movable:
@@ -298,11 +299,14 @@ TEST_SUBMODULE(factory_constructors, m) {
         static void *operator new(size_t, void *p) { py::print("noisy placement new"); return p; }
         static void operator delete(void *p, size_t) { py::print("noisy delete"); ::operator delete(p); }
         static void operator delete(void *, void *) { py::print("noisy placement delete"); }
-#if defined(__PGIC__) || (defined(_MSC_VER) && _MSC_VER < 1910)
+#       if defined(_MSC_VER) && _MSC_VER < 1910
         // MSVC 2015 bug: the above "noisy delete" isn't invoked (fixed in MSVC 2017)
-        static void operator delete(void *p) { py::print("noisy delete"); ::operator delete(p); }
-#endif
+            static void operator delete(void *p) { py::print("noisy delete"); ::operator delete(p); }
+#       endif
     };
+
+    static_assert(py::detail::has_operator_delete_size<NoisyAlloc>::value, "Must have sized delete");
+
     py::class_<NoisyAlloc>(m, "NoisyAlloc")
         // Since these overloads have the same number of arguments, the dispatcher will try each of
         // them until the arguments convert.  Thus we can get a pre-allocation here when passing a