fix: GIL code in some compilers

henryiii · henryiii · commit 4db3dba39e0f · 2025-05-23T15:11:36.000-04:00
Signed-off-by: Henry Schreiner &lt;henryschreineriii@gmail.com&gt;
diff --git a/include/pybind11/critical_section.h b/include/pybind11/critical_section.h
@@ -29,8 +29,8 @@ class scoped_critical_section {
         }
     }
 #else
-    explicit scoped_critical_section(handle _obj) = default;
-    scoped_critical_section(handle _obj1, handle _obj2) = default;
+    explicit scoped_critical_section(handle) {};
+    scoped_critical_section(handle, handle) {};
     ~scoped_critical_section() = default;
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,8 @@ class scoped_critical_section {`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`	`#else`
`32`		`- explicit scoped_critical_section(handle _obj) = default;`
`33`		`- scoped_critical_section(handle _obj1, handle _obj2) = default;`
	`32`	`+ explicit scoped_critical_section(handle) {};`
	`33`	`+ scoped_critical_section(handle, handle) {};`
`34`	`34`	`~scoped_critical_section() = default;`
`35`	`35`	`#endif`
`36`	`36`