Used constexpr value for base object type name

Author: jagerman

include/pybind11/class_support.h

@@ -301,7 +301,8 @@ extern "C" inline void pybind11_object_dealloc(PyObject *self) {
     needed in order to satisfy Python's requirements for multiple inheritance.
     Return value: New reference. */
 inline PyObject *make_object_base_type(PyTypeObject *metaclass) {
-    auto name_obj = reinterpret_steal<object>(PYBIND11_FROM_STRING("pybind11_object"));
+    constexpr auto *name = "pybind11_object";
+    auto name_obj = reinterpret_steal<object>(PYBIND11_FROM_STRING(name));
 
     /* Danger zone: from now (and until PyType_Ready), make sure to
        issue no Python C API calls which could potentially invoke the
@@ -317,7 +318,7 @@ inline PyObject *make_object_base_type(PyTypeObject *metaclass) {
 #endif
 
     auto type = &heap_type->ht_type;
-    type->tp_name = "pybind11_object";
+    type->tp_name = name;
     type->tp_base = &PyBaseObject_Type;
     type->tp_basicsize = static_cast<ssize_t>(sizeof(instance));
     type->tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HEAPTYPE;