Skip to content

Commit 1de8b6c

Browse files
committed
refactor: a few points from @rwgk
1 parent e2bcf40 commit 1de8b6c

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.github/ISSUE_TEMPLATE/bug-report.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Make sure you've completed the following steps before submitting your issue -- t
1111
2. Search the [issue tracker][] to verify that this hasn't already been reported. +1 or comment there if it has.
1212
3. Consider asking first in the [Gitter chat room][].
1313
4. Include a self-contained and minimal piece of code that reproduces the problem. If that's not possible, try to make the description as clear as possible.
14+
a. If possible, make a PR with a new, failing test to give us a starting point to work on!
1415

1516
[documentation]: https://pybind11.readthedocs.io
1617
[issue tracker]: https://github.com/pybind/pybind11/issues

.github/CONTRIBUTING.md renamed to CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ cmake --build build --target check
128128
* `test_cmake_build`: Install / subdirectory tests
129129

130130
If you want to build just a subset of tests, use
131-
`-DPYBIND11_TEST_OVERRIDE="test_callbacks.cpp;test_picking.cpp"`. If this is
131+
`-DPYBIND11_TEST_OVERRIDE="test_callbacks.cpp;test_pickling.cpp"`. If this is
132132
empty, all tests will be built.
133133

134134
### Formatting

tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ set(PYBIND11_TEST_FILES
8484
test_virtual_functions.cpp)
8585

8686
# Invoking cmake with something like:
87-
# cmake -DPYBIND11_TEST_OVERRIDE="test_callbacks.cpp;test_picking.cpp" ..
87+
# cmake -DPYBIND11_TEST_OVERRIDE="test_callbacks.cpp;test_pickling.cpp" ..
8888
# lets you override the tests that get compiled and run. You can restore to all tests with:
8989
# cmake -DPYBIND11_TEST_OVERRIDE= ..
9090
if(PYBIND11_TEST_OVERRIDE)

0 commit comments

Comments
 (0)