Update Marker class #505
Merged
Update Marker class #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing #504 remove field attribute as it is no longer available. adding `__repr__` to Marker class resulting in `<Marker:intro:139770:230481>`
Hellowlol
reviewed
Jun 13, 2020
plexapi/media.py
Outdated
| name = self._clean(self.firstAttr('type')) | ||
| start = self._clean(self.firstAttr('start')) | ||
| end = self._clean(self.firstAttr('end')) | ||
| return '<%s>' % ':'.join([p for p in [self.__class__.__name__, name, start, end] if p]) |
Collaborator
There was a problem hiding this comment.
Since we are adding a repr, lets show the start and end in "human" time in the repr
def sec_to_hh_mm_ss(seconds):
return time.strftime("%H:%M:%S", time.gmtime(seconds))
Collaborator
Author
There was a problem hiding this comment.
Seconds: [<Marker:intro:139770:230481>]
Human: [<Marker:intro:0:02:19:0:03:50>]
Collaborator
Author
There was a problem hiding this comment.
Looks like it's actually milliseconds. I've adjusted the code to fit.
def mill_sec_to_hh_mm_ss(milliseconds):
if not isinstance(milliseconds, int):
milliseconds = cast(int, milliseconds)
hhmmsssm = timedelta(milliseconds=milliseconds)
return str(hhmmsssm).split(".")[0]
Collaborator
There was a problem hiding this comment.
Cant you change it to this one, make the format more correct and is more precice
def ms_to_hh_mm_ms(ms):
r = datetime.datetime.utcfromtimestamp(ms/1000)
f = r.strftime("%H:%M:%S.%f")
return f[:-2]
Collaborator
There was a problem hiding this comment.
Also Change the repr so its [<Marker:intro: 00:02:19 - 00:03:50>]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #504
remove field attribute as it is no longer available.
adding
__repr__to Marker class resulting in<Marker:intro:139770:230481>