Skip to content

Commit b6ea98d

Browse files
committed
Add tests for logos and deleting
1 parent 7dd0d75 commit b6ea98d

File tree

2 files changed

+30
-1
lines changed

2 files changed

+30
-1
lines changed

tests/test_mixins.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,10 @@ def lock_art(obj):
219219
_test_mixins_lock_image(obj, "arts")
220220

221221

222+
def lock_logo(obj):
223+
_test_mixins_lock_image(obj, "logos")
224+
225+
222226
def lock_poster(obj):
223227
_test_mixins_lock_image(obj, "posters")
224228

@@ -228,6 +232,7 @@ def _test_mixins_edit_image(obj, attr):
228232
get_img_method = getattr(obj, attr)
229233
set_img_method = getattr(obj, "set" + cap_attr)
230234
upload_img_method = getattr(obj, "upload" + cap_attr)
235+
delete_img_method = getattr(obj, "delete" + cap_attr)
231236
images = get_img_method()
232237
if images:
233238
default_image = images[0]
@@ -270,6 +275,12 @@ def _test_mixins_edit_image(obj, attr):
270275
]
271276
assert file_image
272277

278+
# Test delete image
279+
delete_img_method()
280+
images = get_img_method()
281+
selected_image = next((i for i in images if i.selected), None)
282+
assert selected_image is None
283+
273284
# Reset to default image
274285
if default_image:
275286
set_img_method(default_image)
@@ -283,6 +294,10 @@ def edit_art(obj):
283294
_test_mixins_edit_image(obj, "arts")
284295

285296

297+
def edit_logo(obj):
298+
_test_mixins_edit_image(obj, "logos")
299+
300+
286301
def edit_poster(obj):
287302
_test_mixins_edit_image(obj, "posters")
288303

@@ -330,9 +345,15 @@ def _test_mixins_edit_theme(obj):
330345
obj.lockTheme()
331346
obj.reload()
332347
assert "theme" in _fields()
348+
349+
# Set the theme
333350
with pytest.raises(NotImplementedError):
334351
obj.setTheme(themes[0])
335352

353+
# Delete the theme
354+
with pytest.raises(NotImplementedError):
355+
obj.deleteTheme()
356+
336357

337358
def edit_theme(obj):
338359
_test_mixins_edit_theme(obj)

tests/test_video.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,8 +694,10 @@ def test_video_Movie_mixins_edit_advanced_settings(movie):
694694
@pytest.mark.xfail(reason="Changing images fails randomly")
695695
def test_video_Movie_mixins_images(movie):
696696
test_mixins.lock_art(movie)
697+
test_mixins.lock_logo(movie)
697698
test_mixins.lock_poster(movie)
698699
test_mixins.edit_art(movie)
700+
test_mixins.edit_logo(movie)
699701
test_mixins.edit_poster(movie)
700702

701703

@@ -961,8 +963,10 @@ def test_video_Show_mixins_edit_advanced_settings(show):
961963
@pytest.mark.xfail(reason="Changing images fails randomly")
962964
def test_video_Show_mixins_images(show):
963965
test_mixins.lock_art(show)
966+
test_mixins.lock_logo(show)
964967
test_mixins.lock_poster(show)
965968
test_mixins.edit_art(show)
969+
test_mixins.edit_logo(show)
966970
test_mixins.edit_poster(show)
967971
test_mixins.attr_artUrl(show)
968972
test_mixins.attr_posterUrl(show)
@@ -1118,8 +1122,10 @@ def test_video_Season_episodes(show):
11181122
def test_video_Season_mixins_images(show):
11191123
season = show.season(season=1)
11201124
test_mixins.lock_art(season)
1125+
test_mixins.lock_logo(season)
11211126
test_mixins.lock_poster(season)
11221127
test_mixins.edit_art(season)
1128+
test_mixins.edit_logo(season)
11231129
test_mixins.edit_poster(season)
11241130
test_mixins.attr_artUrl(season)
11251131
test_mixins.attr_posterUrl(season)
@@ -1336,8 +1342,10 @@ def test_video_Episode_unwatched(tvshows):
13361342
@pytest.mark.xfail(reason="Changing images fails randomly")
13371343
def test_video_Episode_mixins_images(episode):
13381344
test_mixins.lock_art(episode)
1345+
test_mixins.lock_logo(episode)
13391346
test_mixins.lock_poster(episode)
1340-
# test_mixins.edit_art(episode) # Uploading episode artwork is broken in Plex
1347+
test_mixins.edit_art(episode)
1348+
test_mixins.edit_logo(episode)
13411349
test_mixins.edit_poster(episode)
13421350
test_mixins.attr_artUrl(episode)
13431351
test_mixins.attr_posterUrl(episode)

0 commit comments

Comments
 (0)