Skip to content

Conversation

@paf31
Copy link
Contributor

@paf31 paf31 commented Dec 18, 2015

I figured these might make useful alternatives to the usual exhaustivity error message.

@garyb
Copy link
Member

garyb commented Dec 18, 2015

Good thinking 👍

@garyb
Copy link
Member

garyb commented Dec 18, 2015

Maybe we want unsafe versions of these too, without the constraint? So we can replace the unsafeThrow things we have in places currently where we're manually verifying something is not partial? I guess unsafePartial does the same job, but having another option for defining "it's-not-partial-honest" functions with a better fail error might be useful.

@paf31
Copy link
Contributor Author

paf31 commented Dec 18, 2015

How's this?

@garyb
Copy link
Member

garyb commented Dec 18, 2015

👍

paf31 added a commit that referenced this pull request Dec 18, 2015
@paf31 paf31 merged commit 325f4c9 into master Dec 18, 2015
@paf31 paf31 deleted the crash branch December 18, 2015 01:30
@paf31
Copy link
Contributor Author

paf31 commented Dec 18, 2015

Ok, how do I version this again?

@garyb
Copy link
Member

garyb commented Dec 18, 2015

v1.1.0, as it's backwards compatible new features.

@paf31
Copy link
Contributor Author

paf31 commented Dec 18, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants