-
Notifications
You must be signed in to change notification settings - Fork 41
Update for PureScript 0.11 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@garyb this PR can also be merged? |
|
Not quite, there's some changes to come yet. |
c44fe5d to
bae0da0
Compare
|
@paf31 Ok, just pushed a pretty big update...
|
src/Data/Foreign/Index.purs
Outdated
| ixKleisli :: forall i. Index i => F Foreign -> i -> F Foreign | ||
| ixKleisli f i = f >>= (_ ! i) | ||
|
|
||
| infixl 9 ixKleisli as !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought: we could overload ! using a type class here.
paf31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I will probably continue to maintain some of the JSON features in the more opinionated foreign-generics but I think these are the right choices for this library.
No description provided.