Skip to content

Commit 6780e30

Browse files
Drop ImmutableBuffer usage
1 parent 01c1744 commit 6780e30

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

src/Node/Http2/Session.purs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ import Effect (Effect)
5959
import Effect.Exception (Error)
6060
import Effect.Uncurried (EffectFn1, EffectFn2, EffectFn3, EffectFn4, mkEffectFn1, mkEffectFn2, mkEffectFn3, mkEffectFn4, runEffectFn1, runEffectFn2, runEffectFn3, runEffectFn4)
6161
import Node.Buffer (Buffer)
62-
import Node.Buffer.Immutable (ImmutableBuffer)
6362
import Node.EventEmitter (EventEmitter, EventHandle(..))
6463
import Node.EventEmitter.UtilTypes (EventHandle0, EventHandle1, EventHandle2, EventHandle3, EventHandle4)
6564
import Node.Http2.ErrorCode (ErrorCode)
@@ -193,17 +192,17 @@ pendingSettingsAck s = runEffectFn1 pendingSettingsAckImpl s
193192

194193
foreign import pendingSettingsAckImpl :: forall endpoint. EffectFn1 (Http2Session endpoint) (Boolean)
195194

196-
ping :: forall endpoint. Http2Session endpoint -> (Maybe Error -> Milliseconds -> ImmutableBuffer -> Effect Unit) -> Effect Boolean
195+
ping :: forall endpoint. Http2Session endpoint -> (Maybe Error -> Milliseconds -> Buffer -> Effect Unit) -> Effect Boolean
197196
ping s cb = runEffectFn2 pingImpl s $ mkEffectFn3 \err dur payload ->
198197
cb (toMaybe err) dur payload
199198

200-
foreign import pingImpl :: forall endpoint. EffectFn2 (Http2Session endpoint) (EffectFn3 (Nullable Error) Milliseconds ImmutableBuffer Unit) (Boolean)
199+
foreign import pingImpl :: forall endpoint. EffectFn2 (Http2Session endpoint) (EffectFn3 (Nullable Error) Milliseconds Buffer Unit) (Boolean)
201200

202-
pingPayload :: forall endpoint. Http2Session endpoint -> ImmutableBuffer -> (Maybe Error -> Milliseconds -> ImmutableBuffer -> Effect Unit) -> Effect Boolean
201+
pingPayload :: forall endpoint. Http2Session endpoint -> Buffer -> (Maybe Error -> Milliseconds -> Buffer -> Effect Unit) -> Effect Boolean
203202
pingPayload s buf cb = runEffectFn3 pingPayloadImpl s buf $ mkEffectFn3 \err dur payload ->
204203
cb (toMaybe err) dur payload
205204

206-
foreign import pingPayloadImpl :: forall endpoint. EffectFn3 (Http2Session endpoint) ImmutableBuffer (EffectFn3 (Nullable Error) Milliseconds ImmutableBuffer Unit) (Boolean)
205+
foreign import pingPayloadImpl :: forall endpoint. EffectFn3 (Http2Session endpoint) Buffer (EffectFn3 (Nullable Error) Milliseconds Buffer Unit) (Boolean)
207206

208207
ref :: forall endpoint. Http2Session endpoint -> Effect (Socket TCP)
209208
ref s = runEffectFn1 refImpl s

src/Node/Http2/Settings.purs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module Node.Http2.Settings
77

88
import Effect (Effect)
99
import Effect.Uncurried (EffectFn1, runEffectFn1)
10-
import Node.Buffer.Immutable (ImmutableBuffer)
10+
import Node.Buffer (Buffer)
1111
import Node.Http2.Types (Settings)
1212

1313
defaultSettings :: Settings
@@ -23,12 +23,12 @@ defaultSettings =
2323

2424
foreign import getDefaultSettings :: Effect (Settings)
2525

26-
getPackedSettings :: Settings -> Effect ImmutableBuffer
26+
getPackedSettings :: Settings -> Effect Buffer
2727
getPackedSettings s = runEffectFn1 getPackedSettingsImpl s
2828

29-
foreign import getPackedSettingsImpl :: EffectFn1 (Settings) (ImmutableBuffer)
29+
foreign import getPackedSettingsImpl :: EffectFn1 (Settings) (Buffer)
3030

31-
getUnpackedSettings :: ImmutableBuffer -> Effect Settings
31+
getUnpackedSettings :: Buffer -> Effect Settings
3232
getUnpackedSettings buf = runEffectFn1 getUnpackedSettingsImpl buf
3333

34-
foreign import getUnpackedSettingsImpl :: EffectFn1 (ImmutableBuffer) (Settings)
34+
foreign import getUnpackedSettingsImpl :: EffectFn1 (Buffer) (Settings)

test/Test/Main.purs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ import Node.Path as Path
2626
import Node.Stream as Stream
2727
import Unsafe.Coerce (unsafeCoerce)
2828

29-
unsafeToImmutableBuffer :: Buffer.Buffer -> Effect ImmutableBuffer
30-
unsafeToImmutableBuffer = Buffer.unsafeFreeze
31-
3229
logWith :: String -> String -> Effect Unit
3330
logWith msg x = log $ msg <> ": " <> x
3431

0 commit comments

Comments
 (0)