Skip to content

Commit 8716b11

Browse files
authored
Merge pull request #10 from purescript-contrib/fix-shadow-warning
Fix shadow warning
2 parents d9d0376 + 635dcc7 commit 8716b11

File tree

6 files changed

+38
-48
lines changed

6 files changed

+38
-48
lines changed

.eslintrc.json

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"parserOptions": {
3+
"ecmaVersion": 5
4+
},
5+
"extends": "eslint:recommended",
6+
"env": {
7+
"commonjs": true
8+
},
9+
"rules": {
10+
"strict": [2, "global"],
11+
"block-scoped-var": 2,
12+
"consistent-return": 2,
13+
"eqeqeq": [2, "smart"],
14+
"guard-for-in": 2,
15+
"no-caller": 2,
16+
"no-extend-native": 2,
17+
"no-loop-func": 2,
18+
"no-new": 2,
19+
"no-param-reassign": 2,
20+
"no-return-assign": 2,
21+
"no-unused-expressions": 2,
22+
"no-use-before-define": 2,
23+
"radix": [2, "always"],
24+
"indent": [2, 2],
25+
"quotes": [2, "double"],
26+
"semi": [2, "always"]
27+
}
28+
}

.gitignore

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/.*
22
!/.gitignore
3-
!/.jscsrc
4-
!/.jshintrc
3+
!/.eslintrc.json
54
!/.travis.yml
65
/bower_components/
76
/node_modules/

.jscsrc

Lines changed: 0 additions & 17 deletions
This file was deleted.

.jshintrc

Lines changed: 0 additions & 19 deletions
This file was deleted.

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@
22
"private": true,
33
"scripts": {
44
"clean": "rimraf output && rimraf .pulp-cache",
5-
"build": "jshint src && jscs src && pulp build --censor-lib --strict",
5+
"build": "eslint src && pulp build -- --censor-lib --strict",
66
"test": "pulp test"
77
},
88
"devDependencies": {
9-
"jscs": "^3.0.7",
10-
"jshint": "^2.9.3",
11-
"pulp": "^9.0.1",
9+
"eslint": "^3.10.2",
10+
"pulp": "^10.0.0",
1211
"purescript-psa": "^0.3.9",
13-
"purescript": "^0.10.1",
12+
"purescript": "^0.10.2",
1413
"rimraf": "^2.5.4"
1514
}
1615
}

src/Data/Argonaut/JCursor.purs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,13 @@ cursorSet (JIndex i c) v = J.foldJsonArray defaultArr mergeArrs
117117
mergeArrs a =
118118
setArr a i =<< cursorSet c v (fromMaybe (inferEmpty c) (a A.!! i))
119119
setArr :: J.JArray -> Int -> J.Json -> Maybe J.Json
120-
setArr xs i v =
120+
setArr xs i' v' =
121121
let len = A.length xs
122-
in if i < 0
122+
in if i' < 0
123123
then Nothing
124-
else if i >= len
125-
then setArr (xs <> (replicate (i - len + 1) J.jsonNull)) i v
126-
else J.fromArray <$> A.updateAt i v xs
124+
else if i' >= len
125+
then setArr (xs <> (replicate (i' - len + 1) J.jsonNull)) i' v'
126+
else J.fromArray <$> A.updateAt i' v' xs
127127

128128
toPrims :: J.Json -> List (Tuple JCursor JsonPrim)
129129
toPrims = J.foldJson nullFn boolFn numFn strFn arrFn objFn

0 commit comments

Comments
 (0)