Call site display for deprecation warnings

Author: Helen Campbell

lib/puppet/functions/deprecation.rb

@@ -8,15 +8,19 @@
   end
 
   def deprecation(key, message)
+    stacktrace = Puppet::Pops::PuppetStack.stacktrace()
+    file = stacktrace[0]
+    line = stacktrace[1]
+    output_message = "#{message} at #{file}:#{line}"
     # depending on configuration setting of strict
     case Puppet.settings[:strict]
     when :off
       # do nothing
     when :error
-      fail("deprecation. #{key}. #{message}")
+      fail("deprecation. #{key}. #{output_message}")
     else
       unless ENV['STDLIB_LOG_DEPRECATIONS'] == 'false'
-        Puppet.deprecation_warning(message, key)
+        Puppet.deprecation_warning(output_message, key)
       end
     end
   end

spec/acceptance/deprecation_spec.rb

@@ -31,7 +31,7 @@
     end
 
     it "should show the error message" do
-      expect(@result.stderr).to match(/deprecation. key. message/)
+      expect(@result.stderr).to match(/deprecation. key. \$\{message\}/)
     end
 
     describe file("#{test_file}") do
@@ -53,7 +53,7 @@
     end
 
     it "should show the error message" do
-      expect(@result.stderr).to match(/Warning: message/)
+      expect(@result.stderr).to match(/Warning: \$\{message\} at \$\{stacktrace\[0\]\[0\]\}:\$\{stacktrace\[0\]:\[1\]\}/)
     end
 
     describe file("#{test_file}") do