Merge pull request #858 from tphoney/MODULES-6139

MODULES-6139 Revert to old ruby 1.X style of hash

Author: david22swan

.rubocop.yml

@@ -25,6 +25,8 @@ RSpec/BeforeAfterAll:
 RSpec/HookArgument:
   Description: Prefer explicit :each argument, matching existing module's style
   EnforcedStyle: each
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets
 Style/BlockDelimiters:
   Description: Prefer braces for chaining. Mostly an aesthetical choice. Better to
     be consistent then.
@@ -97,4 +99,4 @@ Style/IfUnlessModifier:
 Style/SymbolProc:
   Enabled: false
 RSpec/NamedSubject:
- Enabled: false
+ Enabled: false

lib/facter/facter_dot_d.rb

@@ -119,7 +119,7 @@ def cache_save!
   def cache_store(file, data)
     load_cache
 
-    @cache[file] = { data: data, stored: Time.now.to_i }
+    @cache[file] = { :data => data, :stored => Time.now.to_i }
   rescue # rubocop:disable Lint/HandleExceptions - Is meant to be suppressed
   end
 

lib/facter/package_provider.rb

@@ -13,9 +13,9 @@
 Facter.add(:package_provider) do
   setcode do
     if defined? Gem && Gem::Version.new(Facter.value(:puppetversion).split(' ')[0]) >= Gem::Version.new('3.6')
-      Puppet::Type.type(:package).newpackage(name: 'dummy', allow_virtual: 'true')[:provider].to_s
+      Puppet::Type.type(:package).newpackage(:name => 'dummy', :allow_virtual => 'true')[:provider].to_s
     else
-      Puppet::Type.type(:package).newpackage(name: 'dummy')[:provider].to_s
+      Puppet::Type.type(:package).newpackage(:name => 'dummy')[:provider].to_s
     end
   end
 end

lib/facter/pe_version.rb

@@ -31,7 +31,7 @@
 end
 
 Facter.add('pe_major_version') do
-  confine is_pe: true
+  confine :is_pe => true
   setcode do
     pe_version = Facter.value(:pe_version)
     if pe_version
@@ -41,7 +41,7 @@
 end
 
 Facter.add('pe_minor_version') do
-  confine is_pe: true
+  confine :is_pe => true
   setcode do
     pe_version = Facter.value(:pe_version)
     if pe_version
@@ -51,7 +51,7 @@
 end
 
 Facter.add('pe_patch_version') do
-  confine is_pe: true
+  confine :is_pe => true
   setcode do
     pe_version = Facter.value(:pe_version)
     if pe_version

lib/facter/root_home.rb

@@ -18,7 +18,7 @@ def returnt_root_home
 end
 
 Facter.add(:root_home) do
-  confine kernel: :darwin
+  confine :kernel => :darwin
   setcode do
     str = Facter::Util::Resolution.exec('dscacheutil -q user -a name root')
     hash = {}
@@ -31,7 +31,7 @@ def returnt_root_home
 end
 
 Facter.add(:root_home) do
-  confine kernel: :aix
+  confine :kernel => :aix
   root_home = nil
   setcode do
     str = Facter::Util::Resolution.exec('lsuser -c -a home root')

lib/facter/service_provider.rb

@@ -12,6 +12,6 @@
 
 Facter.add(:service_provider) do
   setcode do
-    Puppet::Type.type(:service).newservice(name: 'dummy')[:provider].to_s
+    Puppet::Type.type(:service).newservice(:name => 'dummy')[:provider].to_s
   end
 end

lib/puppet/parser/functions/abs.rb

@@ -2,7 +2,7 @@
 # abs.rb
 #
 module Puppet::Parser::Functions
-  newfunction(:abs, type: :rvalue, doc: <<-EOS
+  newfunction(:abs, :type => :rvalue, :doc => <<-EOS
     Returns the absolute value of a number, for example -34.56 becomes
     34.56. Takes a single integer and float value as an argument.
     EOS

lib/puppet/parser/functions/any2array.rb

@@ -2,7 +2,7 @@
 # any2array.rb
 #
 module Puppet::Parser::Functions
-  newfunction(:any2array, type: :rvalue, doc: <<-EOS
+  newfunction(:any2array, :type => :rvalue, :doc => <<-EOS
     This converts any object to an array containing that object. Empty argument
     lists are converted to an empty array. Arrays are left untouched. Hashes are
     converted to arrays of alternating keys and values.

lib/puppet/parser/functions/any2bool.rb

@@ -2,7 +2,7 @@
 # any2bool.rb
 #
 module Puppet::Parser::Functions
-  newfunction(:any2bool, type: :rvalue, doc: <<-EOS
+  newfunction(:any2bool, :type => :rvalue, :doc => <<-EOS
     This converts 'anything' to a boolean. In practise it does the following:
 
     * Strings such as Y,y,1,T,t,TRUE,yes,'true' will return true

lib/puppet/parser/functions/assert_private.rb

@@ -2,7 +2,7 @@
 # assert_private.rb
 #
 module Puppet::Parser::Functions
-  newfunction(:assert_private, doc: <<-'EOS'
+  newfunction(:assert_private, :doc => <<-'EOS'
     Sets the current class or definition as private.
     Calling the class or definition from outside the current module will fail.
     EOS