(CONT-801) Fixup some rubocop issues

Author: chelnak

lib/puppet/functions/fqdn_rand_string.rb

@@ -25,7 +25,7 @@
   def fqdn_rand_string(length, charset = '', *seed)
     charset = charset.chars.to_a
 
-    charset = (0..9).map { |i| i.to_s } + ('A'..'Z').to_a + ('a'..'z').to_a if charset.empty?
+    charset = (0..9).map(&:to_s) + ('A'..'Z').to_a + ('a'..'z').to_a if charset.empty?
 
     rand_string = ''
     length.times do |current|

spec/functions/has_interface_with_spec.rb

@@ -22,7 +22,7 @@
                   'network' => '127.0.0.0'
                 },
               ],
-              "bindings6": [
+              bindings6: [
                 {
                   'address' => '::1',
                   'netmask' => 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff',

spec/unit/puppet/provider/file_line/ruby_spec_alter.rb

@@ -34,9 +34,6 @@
   end
 
   describe '#create' do
-    context 'when adding' do
-      pending('To be added.')
-    end
     context 'when replacing' do
       let :params do
         {
@@ -69,9 +66,6 @@
       end
     end
   end
-  describe '#destroy' do
-    pending('To be added?')
-  end
   context 'when matching' do
     # rubocop:disable RSpec/InstanceVariable : replacing before with let breaks the tests, variables need to be altered within it block : multi
     before :each do
@@ -147,9 +141,6 @@
       end
     end
   end
-  context 'when match+replace+append_on_no_match' do
-    pending('to do')
-  end
   context 'when after' do
     let :resource do
       Puppet::Type::File_line.new(