Support extension schemas

Author: hasegeli

README.md

@@ -1192,6 +1192,10 @@ Manages a PostgreSQL extension.
 
 Specifies the database on which to activate the extension.
 
+##### `schema`
+
+Specifies the schema on which to activate the extension.
+
 ##### `ensure`
 
 Specifies whether to activate or deactivate the extension.

manifests/server/extension.pp

@@ -2,6 +2,7 @@
 define postgresql::server::extension (
   $database,
   $extension                   = $name,
+  Optional[String[1]] $schema  = undef,
   Optional[String[1]] $version = undef,
   String[1] $ensure            = 'present',
   $package_name                = undef,
@@ -51,6 +52,33 @@
     unless           => "SELECT 1 WHERE ${unless_mod}EXISTS (SELECT 1 FROM pg_extension WHERE extname = '${extension}')",
   }
 
+  if $ensure == 'present' and $schema {
+    $set_schema_command = "ALTER EXTENSION \"${extension}\" SET SCHEMA \"${schema}\""
+
+    postgresql_psql { "${database}: ${set_schema_command}":
+      command          => $set_schema_command,
+      unless           => @("END")
+        SELECT 1
+        WHERE EXISTS (
+          SELECT 1
+          FROM pg_extension e
+            JOIN pg_namespace n ON e.extnamespace = n.oid
+          WHERE e.extname = '${extension}' AND
+                n.nspname = '${schema}'
+        )
+        |-END
+        ,
+      psql_user        => $user,
+      psql_group       => $group,
+      psql_path        => $psql_path,
+      connect_settings => $connect_settings,
+      db               => $database,
+      require          => Postgresql_psql["${database}: ${command}"],
+    }
+
+    Postgresql::Server::Schema <| db == $database and schema == $schema |> -> Postgresql_psql["${database}: ${set_schema_command}"]
+  }
+
   if $package_name {
     $_package_ensure = $package_ensure ? {
       undef   => $ensure,

spec/unit/defines/server/extension_spec.rb

@@ -40,6 +40,28 @@
     end
   end
 
+  context "when schema is specified" do
+    let (:params) { super().merge({
+      :schema => 'pg_catalog',
+    }) }
+
+    it {
+      is_expected.to contain_postgresql_psql('template_postgis: ALTER EXTENSION "postgis" SET SCHEMA "pg_catalog"')
+    }
+
+    context "when schema is specified again" do
+      let (:pre_condition) { super() + "
+        postgresql::server::extension { #{title}:
+          database => 'template_postgis',
+          schema   => 'pg_catalog',
+      }" }
+
+      it {
+        is_expected.not_to contain_postgresql_psql('template_postgis: ALTER EXTENSION "postgis" SET SCHEMA "pg_catalog"')
+      }
+    end
+  end
+
   context "when setting package name" do
     let (:params) { super().merge({
       :package_name => 'postgis',