Standardize extension command title

Author: hasegeli

manifests/server/extension.pp

@@ -17,13 +17,13 @@
       $command = "CREATE EXTENSION \"${extension}\""
       $unless_mod = ''
       $package_require = []
-      $package_before = Postgresql_psql["Add ${extension} extension to ${database}"]
+      $package_before = Postgresql_psql["${database}: ${command}"]
     }
 
     'absent': {
       $command = "DROP EXTENSION \"${extension}\""
       $unless_mod = 'NOT '
-      $package_require = Postgresql_psql["Add ${extension} extension to ${database}"]
+      $package_require = Postgresql_psql["${database}: ${command}"]
       $package_before = []
     }
 
@@ -39,7 +39,7 @@
     }
   }
 
-  postgresql_psql {"Add ${extension} extension to ${database}":
+  postgresql_psql { "${database}: ${command}":
 
     psql_user        => $user,
     psql_group       => $group,

spec/unit/defines/server/extension_spec.rb

@@ -27,7 +27,7 @@
 
   context "with mandatory arguments only" do
     it {
-      is_expected.to contain_postgresql_psql('Add postgis extension to template_postgis').with({
+      is_expected.to contain_postgresql_psql('template_postgis: CREATE EXTENSION "postgis"').with({
         :db      => 'template_postgis',
         :command => 'CREATE EXTENSION "postgis"',
       }).that_requires('Postgresql::Server::Database[template_postgis]')
@@ -43,7 +43,7 @@
       is_expected.to contain_package('postgis').with({
         :ensure  => 'present',
         :name    => 'postgis',
-      }).that_comes_before('Postgresql_psql[Add postgis extension to template_postgis]')
+      }).that_comes_before('Postgresql_psql[template_postgis: CREATE EXTENSION "postgis"]')
     }
   end
 
@@ -54,7 +54,7 @@
     }) }
 
     it {
-      is_expected.to contain_postgresql_psql('Add postgis extension to template_postgis').with({
+      is_expected.to contain_postgresql_psql('template_postgis: DROP EXTENSION "postgis"').with({
         :db      => 'template_postgis',
         :command => 'DROP EXTENSION "postgis"',
       }).that_requires('Postgresql::Server::Database[template_postgis]')
@@ -73,7 +73,7 @@
       }) }
 
       it {
-        is_expected.to contain_postgresql_psql('Add postgis extension to template_postgis').with({
+        is_expected.to contain_postgresql_psql('template_postgis: DROP EXTENSION "postgis"').with({
           :db      => 'template_postgis',
           :command => 'DROP EXTENSION "postgis"',
         }).that_requires('Postgresql::Server::Database[template_postgis]')
@@ -83,7 +83,7 @@
         is_expected.to contain_package('postgis').with({
           :ensure  => 'present',
           :name    => 'postgis',
-        }).that_requires('Postgresql_psql[Add postgis extension to template_postgis]')
+        }).that_requires('Postgresql_psql[template_postgis: DROP EXTENSION "postgis"]')
       }
     end
   end
@@ -147,7 +147,7 @@
 
   context "with mandatory arguments only" do
     it {
-      is_expected.to contain_postgresql_psql('Add postgis extension to template_postgis2').with({
+      is_expected.to contain_postgresql_psql('template_postgis2: CREATE EXTENSION "postgis"').with({
         :db      => 'template_postgis2',
         :command => 'CREATE EXTENSION "postgis"',
       }).that_requires('Postgresql::Server::Database[template_postgis2]')