Reduce duplication in mod_dir spec test

Author: ekohl

spec/classes/mod/dir_spec.rb

@@ -3,106 +3,31 @@
 require 'spec_helper'
 
 describe 'apache::mod::dir', type: :class do
-  it_behaves_like 'a mod class, without including apache'
-
-  context 'default configuration with parameters on a Debian OS' do
-    include_examples 'Debian 8'
-
-    context 'passing no parameters' do
-      it { is_expected.to contain_class('apache::params') }
-      it { is_expected.to contain_apache__mod('dir') }
-      it do
-        is_expected.to contain_file('dir.conf')
-          .with_content(%r{^DirectoryIndex })
-          .with_content(%r{ index\.html })
-          .with_content(%r{ index\.html\.var })
-          .with_content(%r{ index\.cgi })
-          .with_content(%r{ index\.pl })
-          .with_content(%r{ index\.php })
-          .with_content(%r{ index\.xhtml$})
-      end
-    end
-    context "passing indexes => ['example.txt','fearsome.aspx']" do
-      let :params do
-        { indexes: ['example.txt', 'fearsome.aspx'] }
-      end
-
-      it { is_expected.to contain_file('dir.conf').with_content(%r{ example\.txt }).with_content(%r{ fearsome\.aspx$}) }
-    end
-  end
-  context 'default configuration with parameters on a RedHat OS' do
-    include_examples 'RedHat 6'
-
-    context 'passing no parameters' do
-      it { is_expected.to contain_class('apache::params') }
-      it { is_expected.to contain_apache__mod('dir') }
-      it do
-        is_expected.to contain_file('dir.conf')
-          .with_content(%r{^DirectoryIndex })
-          .with_content(%r{ index\.html })
-          .with_content(%r{ index\.html\.var })
-          .with_content(%r{ index\.cgi })
-          .with_content(%r{ index\.pl })
-          .with_content(%r{ index\.php })
-          .with_content(%r{ index\.xhtml$})
-      end
-    end
-    context "passing indexes => ['example.txt','fearsome.aspx']" do
-      let :params do
-        { indexes: ['example.txt', 'fearsome.aspx'] }
-      end
-
-      it { is_expected.to contain_file('dir.conf').with_content(%r{ example\.txt }).with_content(%r{ fearsome\.aspx$}) }
-    end
-  end
-  context 'default configuration with parameters on a FreeBSD OS' do
-    include_examples 'FreeBSD 9'
-
-    context 'passing no parameters' do
-      it { is_expected.to contain_class('apache::params') }
-      it { is_expected.to contain_apache__mod('dir') }
-      it do
-        is_expected.to contain_file('dir.conf')
-          .with_content(%r{^DirectoryIndex })
-          .with_content(%r{ index\.html })
-          .with_content(%r{ index\.html\.var })
-          .with_content(%r{ index\.cgi })
-          .with_content(%r{ index\.pl })
-          .with_content(%r{ index\.php })
-          .with_content(%r{ index\.xhtml$})
+  ['Debian 8', 'RedHat 6', 'FreeBSD 9', 'Gentoo'].each do |os|
+    context "default configuration with parameters on #{os}" do
+      include_examples os
+
+      context 'passing no parameters' do
+        it { is_expected.to contain_class('apache::params') }
+        it { is_expected.to contain_apache__mod('dir') }
+        it do
+          is_expected.to contain_file('dir.conf')
+            .with_content(%r{^DirectoryIndex })
+            .with_content(%r{ index\.html })
+            .with_content(%r{ index\.html\.var })
+            .with_content(%r{ index\.cgi })
+            .with_content(%r{ index\.pl })
+            .with_content(%r{ index\.php })
+            .with_content(%r{ index\.xhtml$})
+        end
+      end
+      context "passing indexes => ['example.txt','fearsome.aspx']" do
+        let :params do
+          { indexes: ['example.txt', 'fearsome.aspx'] }
+        end
+
+        it { is_expected.to contain_file('dir.conf').with_content(%r{ example\.txt }).with_content(%r{ fearsome\.aspx$}) }
       end
     end
-    context "passing indexes => ['example.txt','fearsome.aspx']" do
-      let :params do
-        { indexes: ['example.txt', 'fearsome.aspx'] }
-      end
-
-      it { is_expected.to contain_file('dir.conf').with_content(%r{ example\.txt }).with_content(%r{ fearsome\.aspx$}) }
-    end
-  end
-  context 'default configuration with parameters on a Gentoo OS' do
-    include_examples 'Gentoo'
-
-    context 'passing no parameters' do
-      it { is_expected.to contain_class('apache::params') }
-      it { is_expected.to contain_apache__mod('dir') }
-      it do
-        is_expected.to contain_file('dir.conf')
-          .with_content(%r{^DirectoryIndex })
-          .with_content(%r{ index\.html })
-          .with_content(%r{ index\.html\.var })
-          .with_content(%r{ index\.cgi })
-          .with_content(%r{ index\.pl })
-          .with_content(%r{ index\.php })
-          .with_content(%r{ index\.xhtml$})
-      end
-    end
-    context "passing indexes => ['example.txt','fearsome.aspx']" do
-      let :params do
-        { indexes: ['example.txt', 'fearsome.aspx'] }
-      end
-
-      it { is_expected.to contain_file('dir.conf').with_content(%r{ example\.txt }).with_content(%r{ fearsome\.aspx$}) }
-    end
   end
 end