Skip to content

Commit 26a13cf

Browse files
committed
(maint) pin rubocop dependencies to work on ruby 2.1
1 parent c1f82bc commit 26a13cf

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

Gemfile

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,20 @@ group :tests do
1212
gem 'license_finder' if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4.0')
1313
gem 'rake', '~> 10.0'
1414
gem 'rspec', '~> 3.0'
15-
gem 'rubocop-rspec'
1615
# rubocop 0.58 throws when testing against ruby 2.1, so pin to the latest,
1716
# unless we're dealing with jruby...
1817
if RUBY_PLATFORM == 'java'
19-
gem 'rubocop'
20-
else
18+
# don't install rubocop on JRuby - we don't need it
19+
elsif Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.2.0')
2120
gem 'rubocop', '0.57.2'
21+
# the last version of parallel to support ruby 2.1
22+
gem 'parallel', '1.13.0'
23+
gem 'rubocop-rspec'
24+
else
25+
# 2.1-compatible analysis was dropped after version 0.58
26+
# This needs to be removed once we drop puppet4 support.
27+
gem 'rubocop', '~> 0.57.0'
28+
gem 'rubocop-rspec'
2229
end
2330
gem 'simplecov-console'
2431
# the test gems required for module testing

0 commit comments

Comments
 (0)