Update for Prometheus Community #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After this is done, we can work on re-adding integration tests. We do similar things in the mysqld_exporter CircleCI config. |
SuperQ
force-pushed
the
superq/community
branch
from
b05a99e to
5fcd5ff
Compare
Contributor
Author
|
Ping @wrouesnel |
roidelapluie
approved these changes
Feb 23, 2021
|
Can you please give a second pass at the README ? still mentions vendoring and mage. |
Add standard Prometheus build setup * CircleCI config * Makefile * Go modules * Golang-CI Lint * promu config * Remove /vendor * Remove mage build * Update READMEs #478 Signed-off-by: Ben Kochie <[email protected]>
SuperQ
force-pushed
the
superq/community
branch
from
5fcd5ff to
b67b69a
Compare
Contributor
Author
|
Ok, I updated the README some more. |
roidelapluie
approved these changes
Feb 23, 2021
roidelapluie
left a comment
roidelapluie
left a comment
There was a problem hiding this comment.
I don't even think that we need to mention vendoring at all but LGTM.
ritbl
pushed a commit
to heniek/postgres_exporter
that referenced
this pull request
Mar 19, 2023
…/superq/community Update for Prometheus Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add standard Prometheus build setup
#478
Fixes: #470
Signed-off-by: Ben Kochie [email protected]