Fix version flag

Use Prometheus common/version to print --version output.
* Add `-h` short help flag.

Fixes: #492

Signed-off-by: Ben Kochie <[email protected]>

Author: SuperQ

cmd/postgres_exporter/postgres_exporter.go

@@ -24,7 +24,6 @@ import (
 	"net/url"
 	"os"
 	"regexp"
-	"runtime"
 	"strconv"
 	"strings"
 	"sync"
@@ -40,22 +39,6 @@ import (
 	"gopkg.in/yaml.v2"
 )
 
-// Branch is set during build to the git branch.
-var Branch string
-
-// BuildDate is set during build to the ISO-8601 date and time.
-var BuildDate string
-
-// Revision is set during build to the git commit revision.
-var Revision string
-
-// Version is set during build to the git describe version
-// (semantic version)-(commitish) form.
-var Version = "0.0.1-rev"
-
-// VersionShort is set during build to the semantic version.
-var VersionShort = "0.0.1"
-
 var (
 	listenAddress          = kingpin.Flag("web.listen-address", "Address to listen on for web interface and telemetry.").Default(":9187").Envar("PG_EXPORTER_WEB_LISTEN_ADDRESS").String()
 	metricPath             = kingpin.Flag("web.telemetry-path", "Path under which to expose metrics.").Default("/metrics").Envar("PG_EXPORTER_WEB_TELEMETRY_PATH").String()
@@ -75,6 +58,8 @@ const (
 	namespace = "pg"
 	// Subsystems.
 	exporter = "exporter"
+	// The name of the exporter.
+	exporterName = "postgres_exporter"
 	// Metric label used for static string data thats handy to send to Prometheus
 	// e.g. version
 	staticLabelName = "static"
@@ -1789,8 +1774,9 @@ func contains(a []string, x string) bool {
 }
 
 func main() {
-	kingpin.Version(fmt.Sprintf("postgres_exporter %s (built with %s)\n", Version, runtime.Version()))
+	kingpin.Version(version.Print(exporterName))
 	log.AddFlags(kingpin.CommandLine)
+	kingpin.HelpFlag.Short('h')
 	kingpin.Parse()
 
 	// landingPage contains the HTML served at '/'.
@@ -1833,11 +1819,7 @@ func main() {
 	}()
 
 	// Setup build info metric.
-	version.Branch = Branch
-	version.BuildDate = BuildDate
-	version.Revision = Revision
-	version.Version = VersionShort
-	prometheus.MustRegister(version.NewCollector("postgres_exporter"))
+	prometheus.MustRegister(version.NewCollector(exporterName))
 
 	prometheus.MustRegister(exporter)