Fix some warnings. Remove unneeded imports.

Author: programmerPhysicist

.github/workflows/codacy.yml

@@ -15,12 +15,13 @@ name: Codacy Security Scan
 
 on:
   push:
-    branches: 
+    branches:
     - master
     - develop
+    - fix-warnings-2
   pull_request:
     # The branches below must be a subset of the branches above
-    branches: 
+    branches:
     - master
     - develop
 

source/hab_task.py

@@ -2,17 +2,8 @@
 """ Implements a Habitica synchronisation task.
 This is borrowed essentially wholesale from scriptabit by DeeDee (see README).
 """
-# Ensure backwards compatibility with Python 2
-from __future__ import (
-    absolute_import,
-    division,
-    print_function,
-    unicode_literals)
-from builtins import *
 from datetime import datetime
 import copy
-import time
-# from tzlocal import get_localzone
 import pytz
 
 from dates import parse_date_utc
@@ -68,7 +59,7 @@ def due(self):
             return date
         elif self.__task_dict['type'] == 'daily':
             if self.__task_dict['isDue'] == True:
-                date = datetime.now().replace(tzinfo=pytz.utc,hour=0,minute=0,second=0,microsecond=0)
+                date = datetime.now().replace(tzinfo=pytz.utc, hour=0, minute=0, second=0, microsecond=0)
             elif self.__task_dict['nextDue'] != '':
                 date = parser.parse(self.__task_dict['nextDue'][0])
             return date
@@ -78,8 +69,6 @@ def due(self):
     @property
     def starting(self):
         """When did the daily start running? (That is, is it active now?)"""
-        from dateutil import parser
-        import datetime
         if self.__task_dict['type'] == 'daily':
             start = parser.parse(self.__task_dictself.__task_dict['startDate'])
         else:
@@ -137,7 +126,6 @@ def dailies_due(self):
     @property
     #Is this task due today?
     def due_now(self):
-        now = time.strftime()
         if self.__task_dict['type'] == 'daily':
             return ''
         else:

source/main.py

@@ -8,7 +8,7 @@
 import pickle
 import time
 import requests
-from dateutil import parser
+# from dateutil import parser
 from hab_task import HabTask
 import config
 

source/one_way_sync.py

@@ -52,6 +52,7 @@ def complete_todoist(todo_api, task_id):
 
 
 def sync_todoist_to_habitica():
+    '''Main function for syncing one-way from Todoist to Habitica '''
     # todayFilter = todo_api.filters.add('todayFilter', 'today')
 
     # Telling the site where the config stuff for Habitica can go and get a list of habitica tasks...
@@ -179,7 +180,7 @@ def sync_todoist_to_habitica():
                         continue
                     else:
                         print("error, check todoist daily")
-            elif hab.dueToday == False:
+            elif not hab.dueToday:
                 try:
                     match_dict[tid]['duelast']
                 except:
@@ -188,7 +189,7 @@ def sync_todoist_to_habitica():
                     # this is me keeping a record of recurring tods being completed or not for some of
                     # the complicated bits
                     match_dict[tid]['duelast'] = 'Yes'
-                if hab.completed == False:
+                if not hab.completed:
                     if match_dict[tid]['duelast'] == 'Yes':
                         if tod.dueToday == 'No':
                             response = main.complete_hab(hab)
@@ -219,7 +220,7 @@ def sync_todoist_to_habitica():
                     print("ERROR: check HAB %s" % tid)
                     # match_dict.pop(tid)
             elif tod.complete == 1:
-                if hab.completed == False:
+                if not hab.completed:
                     response = main.complete_hab(hab)
                     print(response)
                     if response.ok:

source/todo_task.py

@@ -1,25 +1,20 @@
 # -*- coding: utf-8 -*-
 """ Implements a Todoist synchronisation task.
 """
-# Ensure backwards compatibility with Python 2
-from __future__ import (
-    absolute_import,
-    division,
-    print_function,
-    unicode_literals)
-from builtins import *
-from datetime import datetime
-from tzlocal import get_localzone
-
-
+from datetime import datetime, timedelta
+import pytz
+from dateutil import parser
+import main
 #from .dates import parse_date_utc
 #from .task import CharacterAttribute, ChecklistItem, Difficulty, Task
 
 """
 So what if I did todoist work a sliiiightly different way, using all my task IDs?
 """
 
-class TodTask(object):
+
+class TodTask():
+    '''Hold a Todoist task '''
     def __init__(self, task=None):
         """ Initialise the task.
 
@@ -70,7 +65,6 @@ def id(self):
     @property
     #task name
     def history(self):
-        import main
         tod_user = main.tod_login('auth.cfg')
         activity = tod_user.activity.get(object_type='item', object_id = self.__task_dict['id'], event_type='completed')
         return activity
@@ -125,20 +119,17 @@ def due_date(self, date):
     @property
     #due date
     def due(self):
-        from dateutil import parser
-        import datetime
         if self.__task_dict['due'] is not None:
-            date = parser.parse(self.__task_dict['due']['date'])
+            if isinstance(self.__task_dict['due'], dict):
+                date = parser.parse(self.__task_dict['due']['date'])
+            else:
+                date = self.__task_dict['due']
             return date
         return ''
 
     @property
     #is it due TODAY?
     def dueToday(self):
-        from dateutil import parser
-        from datetime import datetime
-        from datetime import timedelta
-        import pytz
         today = datetime.utcnow().replace(tzinfo=pytz.UTC)
         try:
             # that datetime thing is pulling todoist's due dates to my time zone
@@ -163,10 +154,7 @@ def date_string(self):
     @property
     #should it be due today?
     def dueLater(self):
-        from dateutil import parser
-        import datetime
-        import pytz
-        today = datetime.datetime.utcnow().replace(tzinfo=pytz.UTC)
+        today = datetime.utcnow().replace(tzinfo=pytz.UTC)
         try:
             wobble = parser.parse(self.__task_dict['due'])
             dueDate = wobble.date()