Skip to content

Commit 47d3428

Browse files
committed
More todo's
1 parent 29d76eb commit 47d3428

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

java/gradle/src/main/kotlin/ProcessingPlugin.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class ProcessingPlugin @Inject constructor(private val objectFactory: ObjectFact
2828

2929
// TODO: Add to tests
3030
project.dependencies.add("implementation", "org.processing:core:4.4.0")
31-
// TODO: Add tests
31+
// TODO: Add tests to test if code jars are working
3232
project.dependencies.add("implementation", project.fileTree("src").apply { include("**/code/*.jar") })
3333

3434
// Base JOGL and Gluegen dependencies
@@ -113,8 +113,6 @@ class ProcessingPlugin @Inject constructor(private val objectFactory: ObjectFact
113113
val outputDirectory = project.layout.buildDirectory.file( "generated/pde/" + sourceSet.name).get().asFile
114114
sourceSet.java.srcDir(outputDirectory)
115115

116-
// TODO: Support multiple sketches?
117-
118116
val taskName = sourceSet.getTaskName("preprocess", "PDE")
119117
project.tasks.register(taskName, ProcessingTask::class.java) { task ->
120118
task.description = "Processes the ${sourceSet.name} PDE"
@@ -127,6 +125,7 @@ class ProcessingPlugin @Inject constructor(private val objectFactory: ObjectFact
127125
) { task -> task.dependsOn(taskName) }
128126
}
129127

128+
// TODO: get this data from code used within the editor
130129
var settingsFolder = File(System.getProperty("user.home"),".processing")
131130
val osName = System.getProperty("os.name").lowercase()
132131
if (osName.contains("win")) {
@@ -147,6 +146,7 @@ class ProcessingPlugin @Inject constructor(private val objectFactory: ObjectFact
147146

148147
val sketchbook = prefs.getProperty("sketchbook.path.four")
149148

149+
// TODO: Move to ProcessingTask after reading the libs from the sketch
150150
File(sketchbook, "libraries").listFiles { file -> file.isDirectory }?.forEach{
151151
project.dependencies.add("implementation", project.fileTree(it).apply { include("**/*.jar") })
152152
}

java/gradle/src/main/kotlin/ProcessingTask.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ abstract class ProcessingTask : SourceTask() {
2727
fun execute(inputChanges: InputChanges) {
2828
val files: MutableSet<File> = HashSet()
2929
if (inputChanges.isIncremental) {
30-
var rebuildRequired = true
30+
var rebuildRequired = false
3131
for (fileChange: FileChange in inputChanges.getFileChanges(stableSources)) {
3232
if (fileChange.fileType == FileType.FILE) {
3333
if (fileChange.changeType == ChangeType.REMOVED) {

0 commit comments

Comments
 (0)