Skip to content

Changed sustain level to relative #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Changed sustain level to relative #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a711183
Changed sustain level to relative
defrost256 Sep 6, 2018
9c250cb
Updated javadoc comment to represent changes
defrost256 Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/processing/sound/Env.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ public Env(PApplet parent) {
* @param input Input sound source
* @param attackTime Attack time value as a float.
* @param sustainTime Sustain time value as a float.
* @param sustain Sustain level value as a float.
* @param sustain Sustain level value as a float. (as fraction of the input amplitude)
* @param releaseTime Release time value as a float.
**/
public void play(SoundObject input, float attackTime, float sustainTime, float sustainLevel, float releaseTime) {
SegmentedEnvelope env = new SegmentedEnvelope(new double[] {
attackTime, input.amp, // attack
// gradual decay towards sustain level across entire sustain period
sustainTime, sustainLevel, // sustain
sustainTime, sustainLevel * input.amp, // sustain
releaseTime, 0.0 });

// TODO re-use player from fixed or dynamic pool
Expand Down