Merge pull request #6129 from pmarsh-scottlogic/main

fix min() and max() crashing on large arrays

Author: limzykenneth

src/math/calculation.js

@@ -499,10 +499,18 @@ p5.prototype.map = function(n, start1, stop1, start2, stop2, withinBounds) {
  * @return {Number}
  */
 p5.prototype.max = function(...args) {
+  const findMax = arr => {
+    let max = -Infinity;
+    for (let x of arr) {
+      max = x > max ? x : max;
+    }
+    return max;
+  };
+
   if (args[0] instanceof Array) {
-    return Math.max.apply(null, args[0]);
+    return findMax(args[0]);
   } else {
-    return Math.max.apply(null, args);
+    return findMax(args);
   }
 };
 
@@ -547,10 +555,18 @@ p5.prototype.max = function(...args) {
  * @return {Number}
  */
 p5.prototype.min = function(...args) {
+  const findMin = arr => {
+    let min = Infinity;
+    for (let x of arr) {
+      min = x < min ? x : min;
+    }
+    return min;
+  };
+
   if (args[0] instanceof Array) {
-    return Math.min.apply(null, args[0]);
+    return findMin(args[0]);
   } else {
-    return Math.min.apply(null, args);
+    return findMin(args);
   }
 };