Added space between text and link in Get Started page #928
Conversation
|
The space shouldn't be added in the templates themselves as it would be problematic when it comes to translating this page, not all languages use spaces to delineate individual words. The space should be added in the language data files for English and possibly Spanish instead. |
|
Hi @limzykenneth, I removed that space from templates, and instead, I added that space in English translation only as Spanish translation seems all fine to me. |
src/data/en.yml
Outdated
| the p5 online editor, outside the editor you must add the accessibility | ||
| library in your html. To learn more visit | ||
| your-first-sketch7: using p5 with a screen reader tutorial | ||
| your-first-sketch7: ' using p5 with a screen reader tutorial' |
There was a problem hiding this comment.
Shouldn't the space be added to the end of the previous entry before the link instead of being a part of the link itself?
There was a problem hiding this comment.
Yeah, but in another translation as in Spanish, it was added in the link part only.
There was a problem hiding this comment.
No need to match that in this case as the space fits better not as part of this link here.
There was a problem hiding this comment.
Ok, then I will add at the end of the previous entry.
limzykenneth
left a comment
limzykenneth
left a comment
There was a problem hiding this comment.
Thanks for being patient with these reviews here, just one more thing and we can merge
src/data/en.yml
Outdated
| the p5 online editor, outside the editor you must add the accessibility | ||
| library in your html. To learn more visit | ||
| your-first-sketch7: ' using p5 with a screen reader tutorial' | ||
| library in your html. To learn more visit |
There was a problem hiding this comment.
One last thing, the space here will probably get deleted at some point by virtue of being at the end of the line (my text editor for example is setup to trim whitespace at end of line), to prevent that we can enclose the whole string in quotes like you have done the line below.
There was a problem hiding this comment.
Hi @limzykenneth, I don't think it is possible to enclose the text part in quotes here because of the block chomping indicator ">-" used here, and if we even try to use the quotes here, then it's the sole purpose of adding space at every line break will be lost. To resolve the above-mentioned problem, we probably should add space in the link part only.
There was a problem hiding this comment.
Hmm...would using a HTML entity code here work? (  for space for example)
If not then I guess we'll have to revert to adding the space before the link.
There was a problem hiding this comment.
Yeah, sure, it will work here. Thank you so much...
|
Perfect, thanks! |
2 participants
Fixes #926
Changes:
There was no space between text and link, which was making it difficult to read.
Screenshots of the change:
Previously:
After Fix:
