Skip to content

chore(PageHeader): Remove the CSS modules feature flag from the PageHeader component #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

chore(PageHeader): Remove the CSS modules feature flag from the PageHeader component #5877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89e5a3a
Remove the CSS modules feature flag from the PageHeader component
jonrohan Apr 4, 2025
aa1894e
Merge branch 'main' into remove_css_modules_flag_pageheader
jonrohan Apr 4, 2025
615da8d
Pass in div instead of updating toggleSxComponent
jonrohan Apr 8, 2025
2c65f03
Merge branch 'main' into remove_css_modules_flag_pageheader
jonrohan Apr 8, 2025
f3e0c80
Move BaseComponents out of Component creations
jonrohan Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-dodos-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Remove the CSS modules feature flag from the PageHeader component
6 changes: 3 additions & 3 deletions packages/react/src/PageHeader/PageHeader.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('PageHeader', () => {
* They are testing the internal implementation of the component and checking if the component
* is rendering the correct styles.This approach was necessary due to the impracticality of CSS media queries testing with Jest.
*/
it('respects default visibility of ContextArea and renders CSS media styles correctly', () => {
it.skip('respects default visibility of ContextArea and renders CSS media styles correctly', () => {
const expectedStyles = {
'-ms-flex-align': 'center',
'-ms-flex-direction': 'row',
Expand All @@ -71,7 +71,7 @@ describe('PageHeader', () => {
expect.objectContaining(expectedStyles),
)
})
it('respects the hidden prop of ContextArea and renders CSS media styles correctly', () => {
it.skip('respects the hidden prop of ContextArea and renders CSS media styles correctly', () => {
const expectedStyles = {
'-ms-flex-align': 'center',
'-ms-flex-direction': 'row',
Expand Down Expand Up @@ -110,7 +110,7 @@ describe('PageHeader', () => {
),
).toEqual(expect.objectContaining(expectedStyles))
})
it('respects default visibility of LeadingAction and TrailingAction and renders CSS media styles correctly', () => {
it.skip('respects default visibility of LeadingAction and TrailingAction and renders CSS media styles correctly', () => {
const expectedStyles = {
'-ms-flex-align': 'center',
'-webkit-align-items': 'center',
Expand Down
Loading
Loading