-
Notifications
You must be signed in to change notification settings - Fork 646
bugfix(PageHeader): Use font-weight initial to match the styled component styling #5852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fd6cfbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
@jonrohan is there a good VRT test we could add for this or is it already included? |
Included with this react/e2e/components/PageHeader.test.ts Line 362 in 4b166c1
|
Pull Request is not mergeable
It was brought up in https://github.com/orgs/community/discussions/154025 that our commit headers were looking thin. Upon investigation I found that the old style had
font-weight: initial;react/packages/react/src/PageHeader/PageHeader.tsx
Line 740 in eb134ce
And the new style had a primitives variable.
react/packages/react/src/PageHeader/PageHeader.module.css
Line 232 in eb134ce
Changelog
New
Changed
Use
font-weight: initialin PageHeader description to match the styled component styling.Removed
Rollout strategy
Testing & Reviewing
Merge checklist